diff --git a/superset/assets/javascripts/explore/components/ExploreActionButtons.jsx b/superset/assets/javascripts/explore/components/ExploreActionButtons.jsx index 74f9b73348ef3..ec9d214c072b3 100644 --- a/superset/assets/javascripts/explore/components/ExploreActionButtons.jsx +++ b/superset/assets/javascripts/explore/components/ExploreActionButtons.jsx @@ -9,27 +9,28 @@ import { exportChart } from '../exploreUtils'; const propTypes = { canDownload: PropTypes.oneOfType([PropTypes.string, PropTypes.bool]).isRequired, - slice: PropTypes.object, chartStatus: PropTypes.string, latestQueryFormData: PropTypes.object, queryResponse: PropTypes.object, }; export default function ExploreActionButtons({ - canDownload, slice, chartStatus, latestQueryFormData, queryResponse }) { + canDownload, chartStatus, latestQueryFormData, queryResponse }) { const exportToCSVClasses = cx('btn btn-default btn-sm', { 'disabled disabledButton': !canDownload, }); const doExportCSV = exportChart.bind(this, latestQueryFormData, 'csv'); const doExportChart = exportChart.bind(this, latestQueryFormData, 'json'); - if (slice) { - return ( -
- + return ( +
+ {latestQueryFormData && + } - + {latestQueryFormData && + } + {latestQueryFormData && .json - - + } + {latestQueryFormData && .csv - - - -
- ); - } - return ( - + } + +
); } diff --git a/superset/assets/spec/javascripts/explore/components/ExploreActionButtons_spec.jsx b/superset/assets/spec/javascripts/explore/components/ExploreActionButtons_spec.jsx index 506dd23f97bec..545446ecbe6e9 100644 --- a/superset/assets/spec/javascripts/explore/components/ExploreActionButtons_spec.jsx +++ b/superset/assets/spec/javascripts/explore/components/ExploreActionButtons_spec.jsx @@ -8,12 +8,7 @@ import ExploreActionButtons from describe('ExploreActionButtons', () => { const defaultProps = { canDownload: 'True', - slice: { - data: { - csv_endpoint: '', - json_endpoint: '', - }, - }, + latestQueryFormData: {}, queryEndpoint: 'localhost', };