From 8626793655e2d0ecf9896d0f214f962dc20e4665 Mon Sep 17 00:00:00 2001
From: timifasubaa <30888507+timifasubaa@users.noreply.github.com>
Date: Tue, 27 Feb 2018 17:43:37 -0800
Subject: [PATCH] check for access before requesting access (#4469)

---
 superset/views/core.py | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/superset/views/core.py b/superset/views/core.py
index c8101b8a8fc49..5b0ee5f3bc104 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -842,6 +842,15 @@ def request_access(self):
                 .one()
             )
             datasources.add(datasource)
+
+        has_access = all(
+            (
+                datasource and self.datasource_access(datasource)
+                for datasource in datasources
+            ))
+        if has_access:
+            return redirect('/superset/dashboard/{}'.format(dashboard_id))
+
         if request.args.get('action') == 'go':
             for datasource in datasources:
                 access_request = DAR(