From 15ecdeb3ba4eba7c13c88edfb197f255803cac89 Mon Sep 17 00:00:00 2001 From: fabianmenges Date: Wed, 4 Oct 2017 12:40:30 -0400 Subject: [PATCH] Fxing bug in label generation for multiple groupbys (#3594) --- superset/assets/visualizations/nvd3_vis.js | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/superset/assets/visualizations/nvd3_vis.js b/superset/assets/visualizations/nvd3_vis.js index 1353968f729c5..681ceaee8ea95 100644 --- a/superset/assets/visualizations/nvd3_vis.js +++ b/superset/assets/visualizations/nvd3_vis.js @@ -77,17 +77,16 @@ function getMaxLabelSize(container, axisClass) { /* eslint-disable camelcase */ function formatLabel(column, verbose_map) { let label; - if (verbose_map) { - if (Array.isArray(column) && column.length) { - label = verbose_map[column[0]]; - if (column.length > 1) { - label += `, ${column.slice(1).join(', ')}`; - } - } else { - label = verbose_map[column]; + if (Array.isArray(column) && column.length) { + label = verbose_map[column[0]] || column[0]; + if (column.length > 1) { + label += ', '; } + label += column.slice(1).join(', '); + } else { + label = verbose_map[column] || column; } - return label || column; + return label; } /* eslint-enable camelcase */