From e71f10438fc8f4845a26539741092aba01ac9921 Mon Sep 17 00:00:00 2001 From: hantianjiao Date: Sun, 3 Nov 2019 22:28:02 +0800 Subject: [PATCH 1/2] fix(line): overflow symbols should render if clip is false #11549 --- src/chart/line/LineView.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/chart/line/LineView.js b/src/chart/line/LineView.js index 8613fe88ec..6ed1a6392d 100644 --- a/src/chart/line/LineView.js +++ b/src/chart/line/LineView.js @@ -354,7 +354,7 @@ export default ChartView.extend({ // FIXME step not support polar var step = !isCoordSysPolar && seriesModel.get('step'); var clipShapeForSymbol; - if (coordSys && coordSys.getArea) { + if (coordSys && coordSys.getArea && seriesModel.get('clip')) { clipShapeForSymbol = coordSys.getArea(); // Avoid float number rounding error for symbol on the edge of axis extent. // See #7913 and `test/dataZoom-clip.html`. From 208d5ab60a31ea1ed5d4fbf53a8556e0d64b8241 Mon Sep 17 00:00:00 2001 From: hantianjiao Date: Mon, 4 Nov 2019 10:50:07 +0800 Subject: [PATCH 2/2] better way to judge clip or not --- src/chart/line/LineView.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/chart/line/LineView.js b/src/chart/line/LineView.js index 6ed1a6392d..70c27a0277 100644 --- a/src/chart/line/LineView.js +++ b/src/chart/line/LineView.js @@ -354,7 +354,7 @@ export default ChartView.extend({ // FIXME step not support polar var step = !isCoordSysPolar && seriesModel.get('step'); var clipShapeForSymbol; - if (coordSys && coordSys.getArea && seriesModel.get('clip')) { + if (coordSys && coordSys.getArea && seriesModel.get('clip', true)) { clipShapeForSymbol = coordSys.getArea(); // Avoid float number rounding error for symbol on the edge of axis extent. // See #7913 and `test/dataZoom-clip.html`.