From 64539fed9d35d0bb1ebc4a22fbcfb6cd6e219ae8 Mon Sep 17 00:00:00 2001 From: ViniciusCestarii Date: Fri, 21 Jun 2024 08:11:32 -0300 Subject: [PATCH] refactor: move dom.setAttribute('role', 'img') to reduce duplication --- src/visual/aria.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/visual/aria.ts b/src/visual/aria.ts index c19071d187..a184776274 100644 --- a/src/visual/aria.ts +++ b/src/visual/aria.ts @@ -153,8 +153,9 @@ export default function ariaVisual(ecModel: GlobalModel, api: ExtensionAPI) { return; } + dom.setAttribute('role', 'img'); + if (labelModel.get('description')) { - dom.setAttribute('role', 'img'); dom.setAttribute('aria-label', labelModel.get('description')); return; } @@ -242,7 +243,6 @@ export default function ariaVisual(ecModel: GlobalModel, api: ExtensionAPI) { const endSeparator = separatorModel.get('end'); ariaLabel += seriesLabels.join(middleSeparator) + endSeparator; - dom.setAttribute('role', 'img'); dom.setAttribute('aria-label', ariaLabel); } }