Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix homebrew publish script #5044

Merged
merged 6 commits into from
Jan 24, 2023

Conversation

iajoiner
Copy link
Contributor

@iajoiner iajoiner commented Jan 24, 2023

Which issue does this PR close?

Closes #5043.

Rationale for this change

Fix the homebrew publish script:

  1. Change the script so that git parallel fetch works on both Linux and macOS and doesn't error out if the OS is neither.
  2. Fix a typo.
  3. Add documentation so that everyone can run the script.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@iajoiner iajoiner changed the title fix homebrew publish script Fix homebrew publish script Jan 24, 2023
@iajoiner
Copy link
Contributor Author

@andygrove

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @iajoiner

@alamb
Copy link
Contributor

alamb commented Jan 24, 2023

FYI any "no space left on device" CI errors should be fixed by merging up from master to get #5047

@andygrove andygrove merged commit b5d90b6 into apache:master Jan 24, 2023
@ursabot
Copy link

ursabot commented Jan 25, 2023

Benchmark runs are scheduled for baseline = e3f0fce and contender = b5d90b6. b5d90b6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@iajoiner iajoiner deleted the fix-homebrew-script branch January 25, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Homebrew release script has the amount of arguments being incorrect
4 participants