Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs links to logical plans module. #5037

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Update docs links to logical plans module. #5037

merged 1 commit into from
Jan 24, 2023

Conversation

vincev
Copy link
Contributor

@vincev vincev commented Jan 24, 2023

Which issue does this PR close?

Closes #5036 .

Rationale for this change

While browsing the docs I have noticed some links don't work.

What changes are included in this PR?

This PR fixes some docs links to logical plan.

Are these changes tested?

I have generated the docs locally and the links now work.

Are there any user-facing changes?

No

@github-actions github-actions bot added the core Core DataFusion crate label Jan 24, 2023
@vincev vincev changed the title Update links to logical plans module. Update docs links to logical plans module. Jan 24, 2023
@alamb
Copy link
Contributor

alamb commented Jan 24, 2023

Thank you @vincev !

Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@vincev
Copy link
Contributor Author

vincev commented Jan 24, 2023

Nice catch

Thank you happy to help, it looks one check failed I am not sure what is causing the problem, it says Too Many Requests, maybe needs a rerun.

@viirya
Copy link
Member

viirya commented Jan 24, 2023

It looks unrelated error. Let me try to re-run the CI.

@alamb
Copy link
Contributor

alamb commented Jan 24, 2023

🎉

@alamb alamb merged commit cb05490 into apache:master Jan 24, 2023
@alamb
Copy link
Contributor

alamb commented Jan 24, 2023

Thanks @vincev and @viirya

@ursabot
Copy link

ursabot commented Jan 24, 2023

Benchmark runs are scheduled for baseline = c313601 and contender = cb05490. cb05490 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@vincev vincev deleted the docs-links branch January 24, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc links to LogicalPlan in the core package need updating.
4 participants