Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Substrait 0.4.0 #4966

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Upgrade to Substrait 0.4.0 #4966

merged 2 commits into from
Jan 18, 2023

Conversation

mbrobbel
Copy link
Contributor

@mbrobbel mbrobbel commented Jan 18, 2023 •
edited
Loading

Which issue does this PR close?

Closes #4950.

Rationale for this change

Bump to latest substrait crate release.

What changes are included in this PR?

Dependabot's bump commit (#4961) and a commit that handles the rename of the protobuf module to proto.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

dependabot bot and others added 2 commits January 18, 2023 08:11
@dependabot
Update substrait requirement from 0.3 to 0.4
15abcd7 
Updates the requirements on [substrait](https://github.com/substrait-io/substrait-rs) to permit the latest version.
- [Release notes](https://github.com/substrait-io/substrait-rs/releases)
- [Changelog](https://github.com/substrait-io/substrait-rs/blob/main/CHANGELOG.md)
- [Commits](https://github.com/substrait-io/substrait-rs/commits/v0.4.0)

---
updated-dependencies:
- dependency-name: substrait
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@mbrobbel
Handle Substrait's protobuf module rename
b713295
andygrove
andygrove approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbrobbel

@andygrove andygrove merged commit db9214a into apache:master Jan 18, 2023
@mbrobbel mbrobbel deleted the substrait-0.4.0 branch January 18, 2023 14:11
@ursabot
Copy link

ursabot commented Jan 18, 2023

Benchmark runs are scheduled for baseline = 906896b and contender = db9214a. db9214a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andygrove andygrove andygrove approved these changes

Assignees
No one assigned
Labels
substrait
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to substrait 0.4
3 participants
@mbrobbel @ursabot @andygrove