Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Make messages consistent for LogicalPlan::Dml #4953

Merged
merged 2 commits into from
Jan 18, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datafusion/core/src/physical_plan/planner.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1183,7 +1183,7 @@ impl DefaultPhysicalPlanner {
LogicalPlan::Dml(_) => {
// DataFusion is a read-only query engine, but also a library, so consumers may implement this
Err(DataFusionError::Internal(
"Unsupported logical plan: Write".to_string(),
"Unsupported logical plan: Dml".to_string(),
))
}
LogicalPlan::SetVariable(_) => {
Expand Down
2 changes: 1 addition & 1 deletion datafusion/expr/src/logical_plan/plan.rs
Original file line number Diff line number Diff line change
Expand Up @@ -937,7 +937,7 @@ impl LogicalPlan {
Ok(())
}
LogicalPlan::Dml(DmlStatement { table_name, op, .. }) => {
write!(f, "Write: op=[{op}] table=[{table_name}]")
write!(f, "Dml: op=[{op}] table=[{table_name}]")
}
LogicalPlan::Filter(Filter {
predicate: ref expr,
Expand Down
2 changes: 1 addition & 1 deletion datafusion/proto/src/logical_plan/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1346,7 +1346,7 @@ impl AsLogicalPlan for LogicalPlanNode {
"LogicalPlan serde is not yet implemented for DropView",
)),
LogicalPlan::Dml(_) => Err(proto_error(
"LogicalPlan serde is not yet implemented for Write",
"LogicalPlan serde is not yet implemented for Dml",
)),
}
}
Expand Down