Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases: row group filter with missing statistics for decimal data type #4810

Merged
merged 3 commits into from
Jan 5, 2023
Merged

Add test cases: row group filter with missing statistics for decimal data type #4810

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
945c509
add null case for row group filter
liukun4515 Jan 4, 2023
77cd5c0
Apply suggestions from code review
liukun4515 Jan 5, 2023
8eec6b2
Merge remote-tracking branch 'upstream/master' into minior_fix
liukun4515 Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 58 additions & 11 deletions datafusion/core/src/physical_plan/file_format/parquet/row_groups.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,10 +475,21 @@ mod tests {
// c1 > 5, this row group will not be included in the results.
vec![ParquetStatistics::int32(Some(10), Some(20), None, 0, false)],
);
let rgm3 = get_row_group_meta_data(
&schema_descr,
// [1, None]
// c1 > 5, this row group will not be included in the results.
vec![ParquetStatistics::int32(Some(100), None, None, 0, false)],
);
let metrics = parquet_file_metrics();
assert_eq!(
prune_row_groups(&[rgm1, rgm2], None, Some(&pruning_predicate), &metrics),
vec![0]
prune_row_groups(
&[rgm1, rgm2, rgm3],
None,
Some(&pruning_predicate),
&metrics
),
vec![0, 2]
);

// INT32: c1 > 5, but parquet decimal type has different precision or scale to arrow decimal
Expand Down Expand Up @@ -528,15 +539,21 @@ mod tests {
// c1 > 5, this row group will not be included in the results.
vec![ParquetStatistics::int32(Some(0), Some(2), None, 0, false)],
);
let rgm4 = get_row_group_meta_data(
&schema_descr,
// [None, 2]
// c1 > 5, this row group will not be included in the results.
vec![ParquetStatistics::int32(None, Some(2), None, 0, false)],
);
let metrics = parquet_file_metrics();
assert_eq!(
prune_row_groups(
&[rgm1, rgm2, rgm3],
&[rgm1, rgm2, rgm3, rgm4],
None,
Some(&pruning_predicate),
&metrics
),
vec![0, 1]
vec![0, 1, 3]
);

// INT64: c1 < 5, the c1 is decimal(18,2)
Expand Down Expand Up @@ -572,10 +589,20 @@ mod tests {
// [0.1, 0.2]
vec![ParquetStatistics::int64(Some(10), Some(20), None, 0, false)],
);
let rgm3 = get_row_group_meta_data(
&schema_descr,
// [0.1, 0.2]
vec![ParquetStatistics::int64(None, None, None, 0, false)],
);
let metrics = parquet_file_metrics();
assert_eq!(
prune_row_groups(&[rgm1, rgm2], None, Some(&pruning_predicate), &metrics),
vec![1]
prune_row_groups(
&[rgm1, rgm2, rgm3],
None,
Some(&pruning_predicate),
&metrics
),
vec![1, 2]
);

// FIXED_LENGTH_BYTE_ARRAY: c1 = decimal128(100000, 28, 3), the c1 is decimal(18,2)
Expand Down Expand Up @@ -631,13 +658,24 @@ mod tests {
false,
)],
);

let rgm3 = get_row_group_meta_data(
&schema_descr,
vec![ParquetStatistics::fixed_len_byte_array(
None, None, None, 0, false,
)],
);
let metrics = parquet_file_metrics();
assert_eq!(
prune_row_groups(&[rgm1, rgm2], None, Some(&pruning_predicate), &metrics),
vec![1]
prune_row_groups(
&[rgm1, rgm2, rgm3],
None,
Some(&pruning_predicate),
&metrics
),
vec![1, 2]
);

// TODO: BYTE_ARRAY support read decimal from parquet, after the 20.0.0 arrow-rs release
// BYTE_ARRAY: c1 = decimal128(100000, 28, 3), the c1 is decimal(18,2)
// the type of parquet is decimal(18,2)
let schema =
Expand Down Expand Up @@ -683,10 +721,19 @@ mod tests {
false,
)],
);
let rgm3 = get_row_group_meta_data(
&schema_descr,
vec![ParquetStatistics::byte_array(None, None, None, 0, false)],
);
let metrics = parquet_file_metrics();
assert_eq!(
prune_row_groups(&[rgm1, rgm2], None, Some(&pruning_predicate), &metrics),
vec![1]
prune_row_groups(
&[rgm1, rgm2, rgm3],
None,
Some(&pruning_predicate),
&metrics
),
vec![1, 2]
);
}

Expand Down