Sql planner support for rollup/cube/grouping sets ast nodes #4727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks -- I hope to work on getting a sqlparser release out later this week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #2469
Rationale for this change
In preparation for apache/datafusion-sqlparser-rs#771, add support in Sql planner for rollup/cube/groupingsets ast nodes. Tests added utilize postgresql dialect, since this already parses rollup/cube/groupingsets properly into the ast, whereas current generic dialect only accounts for rollup/cube (as functions, not as their actual ast nodes)
What changes are included in this PR?
Are these changes tested?
added temporary tests for postgresql dialect, which can be removed once generic dialect will also support this parsing
Are there any user-facing changes?