Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line that prevents display_name from being called on Wildcard #4682

Merged
merged 2 commits into from
Dec 21, 2022
Merged

Add line that prevents display_name from being called on Wildcard #4682

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92370c4
Add line that prevents display_name from being called on Wildcard
andre-cc-natzka Dec 14, 2022
315c451
Move wildcard line to create_name()
andre-cc-natzka Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions datafusion/expr/src/expr.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1253,9 +1253,7 @@ fn create_name(e: &Expr) -> Result<String> {
Expr::Sort { .. } => Err(DataFusionError::Internal(
"Create name does not support sort expression".to_string(),
)),
Expr::Wildcard => Err(DataFusionError::Internal(
"Create name does not support wildcard".to_string(),
)),
Expr::Wildcard => Ok("*".to_string()),
Expr::QualifiedWildcard { .. } => Err(DataFusionError::Internal(
"Create name does not support qualified wildcard".to_string(),
)),
Expand Down