Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve the TryCast expression in columnize_expr #4574

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Preserve the TryCast expression in columnize_expr #4574

merged 1 commit into from
Dec 13, 2022

Conversation

jonahgao
Copy link
Member

Which issue does this PR close?

None
Related to pr #4137

Rationale for this change

Generate a logical plan for query :
SELECT TRY_CAST(SUM(age) AS FLOAT) FROM person

Expected plan:

Projection: TRY_CAST(SUM(person.age) AS Float32)
     Aggregate: groupBy=[[]], aggr=[[SUM(person.age)]]
          TableScan: person

Actual plan:

Projection: SUM(person.age)
     Aggregate: groupBy=[[]], aggr=[[SUM(person.age)]]
          TableScan: person

The try_cast expression is dropped.

What changes are included in this PR?

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@github-actions github-actions bot added logical-expr Logical plan and expressions sql SQL Planner labels Dec 10, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally like this change -- thank you @byteink

However I believe there was discussion previously perhaps from @andygrove or @liukun4515 or @mingmwang about if casts should appear in expression display. Perhaps they would weigh in on this change

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @byteink

@liukun4515 and @andygrove any concerns about merging this PR?

@liukun4515
Copy link
Contributor

I personally like this change -- thank you @byteink

However I believe there was discussion previously perhaps from @andygrove or @liukun4515 or @mingmwang about if casts should appear in expression display. Perhaps they would weigh in on this change

I think we can fill a new issue to discuss about if casts should appear in expression display.

we can merge it first.

@alamb alamb merged commit b3d1cb1 into apache:master Dec 13, 2022
@ursabot
Copy link

ursabot commented Dec 13, 2022

Benchmark runs are scheduled for baseline = b822b0e and contender = b3d1cb1. b3d1cb1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logical-expr Logical plan and expressions sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants