Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reuse code utils::optimize_children instead of redundant implementation #4119

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

jackwener
Copy link
Member

@jackwener jackwener commented Nov 6, 2022

Which issue does this PR close?

Closes #4120.

Rationale for this change

What changes are included in this PR?

Each rule implement optimize_children inside themselves.

We can reuse code utils::optimize_children instead of redundant implementation.

It's also related with #3972, I will remove all optimize_children in it.

Are there any user-facing changes?

@github-actions github-actions bot added the optimizer Optimizer rules label Nov 6, 2022
@jackwener
Copy link
Member Author

About common_subexpr_eliminate.rs, refactor it may affect inline.
I don't ensure it, so I seperately new a PR #4121.

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. Thanks @jackwener

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jackwener -- I really like that the code is becoming more uniform ❤️

@alamb alamb merged commit 7f0778c into apache:master Nov 7, 2022
@ursabot
Copy link

ursabot commented Nov 7, 2022

Benchmark runs are scheduled for baseline = 532b4a7 and contender = 7f0778c. 7f0778c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@jackwener jackwener deleted the optimize_children branch November 9, 2022 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimizer Optimizer rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reuse code utils::optimize_children instead of redundant implementation
4 participants