Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test for #3105 #3116

Closed
wants to merge 1 commit into from
Closed

Conversation

jonmmease
Copy link
Contributor

Which issue does this PR close?

Adds a failing test for #3105. I don't really understand the issue, and I don't currently plan to try to fix this myself, but I though it might by helpful to have the failing test for others to take a look at. If any of the maintainers are available to take a look, feel free to take over this branch.

@jonmmease jonmmease marked this pull request as draft August 12, 2022 11:24
@github-actions github-actions bot added the core Core DataFusion crate label Aug 12, 2022
@jonmmease
Copy link
Contributor Author

Test failure on CI

 ---- exact_median stdout ----
thread 'exact_median' panicked at 'unexpected accumulator state in hash aggregate: Internal("AggregateState is not a scalar aggregate")', datafusion\core\src\physical_plan\aggregates\hash.rs:434:34
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'exact_median' panicked at 'called `Result::unwrap()` on an `Err` value: ArrowError(ExternalError(Execution("Join Error: task 7 panicked")))', datafusion\core\tests\dataframe.rs:463:38

@alamb
Copy link
Contributor

alamb commented Jan 14, 2023

#3105 has been fixed and the fix included tests so I don't think this PR is needed anymore. Thanks again @jonmmease

@alamb alamb closed this Jan 14, 2023
@jonmmease
Copy link
Contributor Author

Sure thing, thanks for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants