Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy failures on main: error: use of deprecated function functions::make_scalar_function` #8973

Closed
alamb opened this issue Jan 23, 2024 · 0 comments · Fixed by #8972
Closed
Assignees
Labels
bug Something isn't working

Comments

@alamb
Copy link
Contributor

alamb commented Jan 23, 2024

Describe the bug

CI checks are failing on main: https://github.com/apache/arrow-datafusion/actions/runs/7628515989/job/20779877406

error: use of deprecated function `functions::make_scalar_function`: Implement your function directly in terms of ColumnarValue or use `ScalarUDF` instead
   --> datafusion/physical-expr/src/functions.rs:562:17
    |
562 |                 make_scalar_function(string_expressions::instr::<i32>)(args)
    |                 ^^^^^^^^^^^^^^^^^^^^
    |
    = note: `-D deprecated` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(deprecated)]`

To Reproduce

CI

Expected behavior

Passing CI / local clippy run

Additional context

I believe this is a logical conflict between #8862 and #8878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant