refactor: make Ctes a struct to also store data types provided by pre…

…pare stmt (#4520) * refactor: make Ctes a struct to also store data types provided by prepare stmt * chore: rename ctes to planner_context
apache · Dec 6, 2022 · bfd41a3 · bfd41a3
1 parent d9a47d6
commit bfd41a3
Show file tree

Hide file tree

Showing 2 changed files with 236 additions and 147 deletions.
diff --git a/datafusion/core/tests/sqllogictests/src/insert/mod.rs b/datafusion/core/tests/sqllogictests/src/insert/mod.rs
@@ -24,9 +24,8 @@ use datafusion::datasource::MemTable;
 use datafusion::prelude::SessionContext;
 use datafusion_common::{DFSchema, DataFusionError};
 use datafusion_expr::Expr as DFExpr;
-use datafusion_sql::planner::SqlToRel;
+use datafusion_sql::planner::{PlannerContext, SqlToRel};
 use sqlparser::ast::{Expr, SetExpr, Statement as SQLStatement};
-use std::collections::HashMap;
 use std::sync::Arc;
 
 pub async fn insert(ctx: &SessionContext, insert_stmt: &SQLStatement) -> Result<String> {
@@ -66,7 +65,11 @@ pub async fn insert(ctx: &SessionContext, insert_stmt: &SQLStatement) -> Result<
         let logical_exprs = row
             .into_iter()
             .map(|expr| {
-                sql_to_rel.sql_to_rex(expr, &DFSchema::empty(), &mut HashMap::new())
+                sql_to_rel.sql_to_rex(
+                    expr,
+                    &DFSchema::empty(),
+                    &mut PlannerContext::new(),
+                )
             })
             .collect::<std::result::Result<Vec<DFExpr>, DataFusionError>>()?;
         // Directly use `select` to get `RecordBatch`