Skip to content

Commit

Permalink
Simplify parquet filter predicate test, fix Page Filtering Incorrectl…
Browse files Browse the repository at this point in the history
…y Handles Pages with Different Row Counts (#4743)

* Simplify filter predicate test

* Fix pruning logic (#4744)

* Format

* Fix oom_sort

* Fix tests

* Format

* Clippy

* Clippy
  • Loading branch information
tustvold authored Dec 28, 2022
1 parent 3abbffb commit 40bf559
Show file tree
Hide file tree
Showing 5 changed files with 235 additions and 181 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ fn prune_pages_in_one_row_group(
let mut sum_row = *row_vec.first().unwrap();
let mut selected = *values.first().unwrap();
trace!("Pruned to to {:?} using {:?}", values, pruning_stats);
for (i, &f) in values.iter().skip(1).enumerate() {
for (i, &f) in values.iter().enumerate().skip(1) {
if f == selected {
sum_row += *row_vec.get(i).unwrap();
} else {
Expand Down
Loading

0 comments on commit 40bf559

Please sign in to comment.