use GetIndexedFieldExpr directly

Author: Igosuki

datafusion/src/physical_plan/expressions/get_indexed_field.rs

@@ -101,11 +101,3 @@ impl PhysicalExpr for GetIndexedFieldExpr {
         }
     }
 }
-
-/// Create a `.[field]` expression
-pub fn get_indexed_field(
-    arg: Arc<dyn PhysicalExpr>,
-    key: ScalarValue,
-) -> Result<Arc<dyn PhysicalExpr>> {
-    Ok(Arc::new(GetIndexedFieldExpr::new(arg, key)))
-}

datafusion/src/physical_plan/expressions/mod.rs

@@ -65,7 +65,7 @@ pub use cast::{
 pub use column::{col, Column};
 pub use count::Count;
 pub use cume_dist::cume_dist;
-pub use get_indexed_field::{get_indexed_field, GetIndexedFieldExpr};
+pub use get_indexed_field::GetIndexedFieldExpr;
 pub use in_list::{in_list, InListExpr};
 pub use is_not_null::{is_not_null, IsNotNullExpr};
 pub use is_null::{is_null, IsNullExpr};

datafusion/src/physical_plan/planner.rs

@@ -32,7 +32,9 @@ use crate::physical_optimizer::optimizer::PhysicalOptimizerRule;
 use crate::physical_plan::cross_join::CrossJoinExec;
 use crate::physical_plan::explain::ExplainExec;
 use crate::physical_plan::expressions;
-use crate::physical_plan::expressions::{CaseExpr, Column, Literal, PhysicalSortExpr};
+use crate::physical_plan::expressions::{
+    CaseExpr, Column, GetIndexedFieldExpr, Literal, PhysicalSortExpr,
+};
 use crate::physical_plan::filter::FilterExec;
 use crate::physical_plan::hash_aggregate::{AggregateMode, HashAggregateExec};
 use crate::physical_plan::hash_join::HashJoinExec;
@@ -969,10 +971,18 @@ impl DefaultPhysicalPlanner {
             Expr::IsNotNull(expr) => expressions::is_not_null(
                 self.create_physical_expr(expr, input_dfschema, input_schema, ctx_state)?,
             ),
-            Expr::GetIndexedField { expr, key } => expressions::get_indexed_field(
-                self.create_physical_expr(expr, input_dfschema, input_schema, ctx_state)?,
-                key.clone(),
-            ),
+            Expr::GetIndexedField { expr, key } => {
+                Ok(Arc::new(GetIndexedFieldExpr::new(
+                    self.create_physical_expr(
+                        expr,
+                        input_dfschema,
+                        input_schema,
+                        ctx_state,
+                    )?,
+                    key.clone(),
+                )))
+            }
+
             Expr::ScalarFunction { fun, args } => {
                 let physical_args = args
                     .iter()