Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support grouping sets parsing for GenericDialect #771

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Support grouping sets parsing for GenericDialect #771

merged 1 commit into from
Dec 28, 2022

Conversation

Jefffrey
Copy link
Contributor

Part of apache/datafusion#2469

To allow GenericDialect to parse Grouping sets.

Note that will also now parse rollup & cube as their Expr enum variant now, instead of as Expr::Function

@Jefffrey Jefffrey mentioned this pull request Dec 25, 2022
Closed
@alamb alamb changed the title Enable grouping sets parsing for GenericDialect Support grouping sets parsing for GenericDialect Dec 28, 2022
alamb
alamb approved these changes Dec 28, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Jefffrey

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3775315706

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.336%
Totals Coverage Status
Change from base Build 3720056662: 0.0%
Covered Lines: 12770
Relevant Lines: 14791
💛 - Coveralls

@alamb alamb merged commit f0870fd into apache:main Dec 28, 2022
@Jefffrey Jefffrey deleted the generic_dialect_grouping_sets branch December 28, 2022 19:55
@alamb alamb mentioned this pull request Dec 29, 2022
Merged
@Jefffrey Jefffrey mentioned this pull request Dec 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jefffrey @coveralls @alamb