Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branding image should be deleted after new image uploaded #589

Closed
cruvie opened this issue Oct 26, 2023 · 3 comments
Closed

branding image should be deleted after new image uploaded #589

cruvie opened this issue Oct 26, 2023 · 3 comments
Assignees
@LinkinStars
Labels
bug Something isn't working

Comments

@cruvie
Copy link

cruvie commented Oct 26, 2023 •
edited
Loading

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. deploy with docker-compose

  2. upload brand image twice

  3. check path /answer-data/uploads/branding

  4. See two images include the previous one

Expected behavior
the previous image should be deleted

Platform (please complete the following information):

  • Device: Desktop
  • OS: macOS
  • Browser edge
  • Version 1.2.0
@cruvie cruvie added the bug Something isn't working label Oct 26, 2023
@fenbox fenbox added this to the v1.2.1 milestone Nov 8, 2023
@fenbox fenbox moved this to Todo in Answer Roadmap Nov 8, 2023
@fenbox fenbox moved this from Todo to In Progress in Answer Roadmap Nov 8, 2023
@kelvinkuo
Copy link
Contributor

kelvinkuo commented Nov 15, 2023 •
edited
Loading

Is this so important? Changing logo is a very low frequency operation. So disk wasting is not too much.
Maybe there will be a feature like "recovering the last logo" some day and need keeping the last logo on disk.

My personal thoughts.

@cruvie

@fenbox fenbox removed this from Answer Roadmap Dec 14, 2023
@fenbox fenbox removed this from the v1.2.1 milestone Dec 14, 2023
@Octobug
Copy link
Contributor

Octobug commented Mar 25, 2024 •
edited
Loading

This is relevant to apache/answer-plugins#257 , which provides a management UI for uploads.

@fenbox
Copy link
Member

fenbox commented Mar 14, 2025

Duplicate of #1204

@fenbox fenbox marked this as a duplicate of #1204 Mar 14, 2025
@fenbox fenbox closed this as completed Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LinkinStars LinkinStars

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fenbox @kelvinkuo @Octobug @LinkinStars @cruvie