Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace existing code with calls to irc-proto #1

Open
aoeixsz4 opened this issue Jul 19, 2021 · 1 comment
Open

Replace existing code with calls to irc-proto #1

aoeixsz4 opened this issue Jul 19, 2021 · 1 comment

Comments

@aoeixsz4
Copy link
Owner

why reinvent the wheel when somebody made an IRCv3 compliant protocol lib
@aoeixsz4
Copy link
Owner Author

Importing irc_proto::chan::ChannelExt and replacing my own valid_channel(&str) with a method that calls foo.to_string().is_channel_name() provided by the library causes my unit tests to fail. 🤔
So, check RFCs, add unit tests to irc-proto and fix it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aoeixsz4