Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom study OK button should be disabled if we know there are no cards #3669

Open
Arthur-Milchior opened this issue Dec 26, 2024 · 1 comment

Comments

@Arthur-Milchior
Copy link
Contributor

how to reproduce:

  • Have an empty deck
  • open the custom study
  • select review ahead

Expected result:

  • Okay should be disabled

Actual result

  • You can tap okay and get the result "No cards matched the criteria you provided"

I understand that this knowing if the criteria is matched is asynchronous. In some case, I guess it can be slow to know whether "ok" would do anything or not. I assume however that in a lot of case, it'd be quick to either see whether "ok" would lead to more reviews or not.

Because, right now, I find it slightly absurd that Anki (and ankidroid) requires me to tap on "ok" to be able to learn something that it could have told me earlier.

My suggestion would be:

  • when the criteria change, start checking whether "ok" would lead to reviewing more cards
  • if after .2 seconds (or some other standard delay), no answer is found, enable "ok" button, (maybe with a spinner instead of "ok")
  • when the answer is found, enable or disable (and remove the spinner)
@dae
Copy link
Member

dae commented Jan 12, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants