Skip to content

angular-cli deploy to ftp with assets #2589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dolanmiu opened this issue Oct 8, 2016 · 8 comments
Closed

angular-cli deploy to ftp with assets #2589

dolanmiu opened this issue Oct 8, 2016 · 8 comments

Comments

@dolanmiu
Copy link

dolanmiu commented Oct 8, 2016

Hi, very simple question here,

I would like to deploy my app via FTP. Which folders do I need to upload after it is built to dist?

I cannot upload just the dist folder because it does not contain my assets.

Do I need to upload my dist AND my src folder? The src folder contains the assets folder

It seems redundant if I have to upload my dist and the source JS files no?

@deebloo
Copy link
Contributor

deebloo commented Oct 8, 2016

@dolanmiu everything you need should be in the dist folder. your assets should also be copied over based on the assets directory you define in your angular-cli.json file

@dolanmiu
Copy link
Author

dolanmiu commented Oct 8, 2016

Are you sure?

screen shot 2016-10-08 at 17 46 09

Here is my angular-cli.json:

https://github.com/dolanmiu/qmtis-website/blob/master/angular-cli.json#L10

@dolanmiu
Copy link
Author

dolanmiu commented Oct 8, 2016

Sorry, yeah I'm dumb, forgot to add --prod after ng build

ng build --prod fixes the issue

@dolanmiu
Copy link
Author

dolanmiu commented Oct 8, 2016

Having said that.. the favicon.ico isnt copied over

@asaph26
Copy link

asaph26 commented Oct 8, 2016

@dolanmiu This an open issue with the angular-cli that is not resolved yet. You have to copy the files manually or through a script.

More info here. #2137

@dolanmiu
Copy link
Author

dolanmiu commented Oct 9, 2016

I think the release today (beta-17) fixes this issue. I haven't used it yet, but from reading the commit history, I can see:

v1.0.0-beta.17...master#diff-ee1c44b86beb3967c38917e8b61c031aR12

@filipesilva
Copy link
Contributor

@dolanmiu that commit does fix it, but was not included in beta.17. Should be in the next version.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants