Skip to content

Commit 8ef3001

Browse files
authored
Enable depend_on_referenced_packages lint (flutter#6498)
1 parent 4b2a636 commit 8ef3001

File tree

54 files changed

+108
-15
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+108
-15
lines changed

analysis_options.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ linter:
114114
# - constant_identifier_names # needs an opt-out https://github.com/dart-lang/linter/issues/204
115115
- control_flow_in_finally
116116
# - curly_braces_in_flow_control_structures # not required by flutter style
117-
# - depend_on_referenced_packages # LOCAL CHANGE - Needs to be enabled and violations fixed.
117+
- depend_on_referenced_packages
118118
- deprecated_consistency
119119
# - diagnostic_describe_all_properties # enabled only at the framework level (packages/flutter/lib)
120120
- directives_ordering

packages/camera/camera_android/example/pubspec.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ dependencies:
1414
# The example app is bundled with the plugin so we use a path dependency on
1515
# the parent directory to use the current plugin's version.
1616
path: ../
17+
camera_platform_interface: ^2.2.0
1718
flutter:
1819
sdk: flutter
1920
path_provider: ^2.0.0

packages/camera/camera_android_camerax/example/pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ dependencies:
1414
# The example app is bundled with the plugin so we use a path dependency on
1515
# the parent directory to use the current plugin's version.
1616
path: ../
17+
camera_platform_interface: ^2.2.0
1718
flutter:
1819
sdk: flutter
1920

@@ -25,4 +26,3 @@ dev_dependencies:
2526

2627
flutter:
2728
uses-material-design: true
28-

packages/camera/camera_avfoundation/example/pubspec.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ dependencies:
1414
# The example app is bundled with the plugin so we use a path dependency on
1515
# the parent directory to use the current plugin's version.
1616
path: ../
17+
camera_platform_interface: ^2.2.0
1718
flutter:
1819
sdk: flutter
1920
path_provider: ^2.0.0

packages/camera/camera_web/example/pubspec.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,11 @@ dependencies:
1010
sdk: flutter
1111

1212
dev_dependencies:
13+
async: ^2.5.0
14+
camera_platform_interface: ^2.1.0
1315
camera_web:
1416
path: ../
17+
cross_file: ^0.3.1
1518
flutter_driver:
1619
sdk: flutter
1720
flutter_test:

packages/camera/camera_windows/example/pubspec.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ dependencies:
1919
sdk: flutter
2020

2121
dev_dependencies:
22+
async: ^2.5.0
2223
flutter_test:
2324
sdk: flutter
2425
integration_test:

packages/file_selector/file_selector_web/example/pubspec.yaml

+3-2
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,13 @@ environment:
66
flutter: ">=2.10.0"
77

88
dependencies:
9+
file_selector_platform_interface: ^2.1.0
10+
file_selector_web:
11+
path: ../
912
flutter:
1013
sdk: flutter
1114

1215
dev_dependencies:
13-
file_selector_web:
14-
path: ../
1516
flutter_driver:
1617
sdk: flutter
1718
flutter_test:

packages/google_maps_flutter/google_maps_flutter/example/pubspec.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ dev_dependencies:
2525
espresso: ^0.1.0+2
2626
flutter_driver:
2727
sdk: flutter
28+
flutter_test:
29+
sdk: flutter
2830
integration_test:
2931
sdk: flutter
3032

packages/google_maps_flutter/google_maps_flutter_android/example/pubspec.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ dev_dependencies:
2525
espresso: ^0.1.0+2
2626
flutter_driver:
2727
sdk: flutter
28+
flutter_test:
29+
sdk: flutter
2830
integration_test:
2931
sdk: flutter
3032

packages/google_maps_flutter/google_maps_flutter_ios/example/pubspec.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,13 @@ dependencies:
1818
# The example app is bundled with the plugin so we use a path dependency on
1919
# the parent directory to use the current plugin's version.
2020
path: ../
21+
google_maps_flutter_platform_interface: ^2.2.1
2122

2223
dev_dependencies:
2324
flutter_driver:
2425
sdk: flutter
26+
flutter_test:
27+
sdk: flutter
2528
integration_test:
2629
sdk: flutter
2730

packages/google_maps_flutter/google_maps_flutter_web/example/pubspec.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ environment:
99
dependencies:
1010
flutter:
1111
sdk: flutter
12+
google_maps_flutter_platform_interface: ^2.2.1
1213
google_maps_flutter_web:
1314
path: ../
1415

packages/google_sign_in/google_sign_in/example/pubspec.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ dev_dependencies:
2222
espresso: ^0.1.0+2
2323
flutter_driver:
2424
sdk: flutter
25+
flutter_test:
26+
sdk: flutter
2527
integration_test:
2628
sdk: flutter
2729

packages/google_sign_in/google_sign_in_android/example/pubspec.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ dev_dependencies:
2323
espresso: ^0.1.0+2
2424
flutter_driver:
2525
sdk: flutter
26+
flutter_test:
27+
sdk: flutter
2628
integration_test:
2729
sdk: flutter
2830

packages/google_sign_in/google_sign_in_ios/example/pubspec.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ dependencies:
2222
dev_dependencies:
2323
flutter_driver:
2424
sdk: flutter
25+
flutter_test:
26+
sdk: flutter
2527
integration_test:
2628
sdk: flutter
2729

packages/google_sign_in/google_sign_in_web/example/pubspec.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ dev_dependencies:
1616
sdk: flutter
1717
flutter_test:
1818
sdk: flutter
19+
google_sign_in_platform_interface: ^2.2.0
1920
http: ^0.13.0
2021
integration_test:
2122
sdk: flutter

packages/image_picker/image_picker/example/pubspec.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ dev_dependencies:
2323
espresso: ^0.2.0
2424
flutter_driver:
2525
sdk: flutter
26+
flutter_test:
27+
sdk: flutter
2628
integration_test:
2729
sdk: flutter
2830

packages/image_picker/image_picker_android/example/pubspec.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ dev_dependencies:
2424
espresso: ^0.2.0
2525
flutter_driver:
2626
sdk: flutter
27+
flutter_test:
28+
sdk: flutter
2729
integration_test:
2830
sdk: flutter
2931

packages/image_picker/image_picker_for_web/example/pubspec.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ dependencies:
1010
sdk: flutter
1111
image_picker_for_web:
1212
path: ../
13+
image_picker_platform_interface: ^2.2.0
1314

1415
dev_dependencies:
1516
flutter_driver:

packages/image_picker/image_picker_ios/example/pubspec.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ dependencies:
2222
dev_dependencies:
2323
flutter_driver:
2424
sdk: flutter
25+
flutter_test:
26+
sdk: flutter
2527
integration_test:
2628
sdk: flutter
2729

packages/image_picker/image_picker_windows/example/pubspec.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ environment:
1010
dependencies:
1111
flutter:
1212
sdk: flutter
13+
image_picker_platform_interface: ^2.4.3
1314
image_picker_windows:
1415
# When depending on this package from a real application you should use:
1516
# image_picker_windows: ^x.y.z

packages/in_app_purchase/in_app_purchase/example/pubspec.yaml

+4-1
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,15 @@ dependencies:
1616
# The example app is bundled with the plugin so we use a path dependency on
1717
# the parent directory to use the current plugin's version.
1818
path: ../
19+
in_app_purchase_android: ^0.2.1
20+
in_app_purchase_storekit: ^0.3.0+1
1921
shared_preferences: ^2.0.0
2022

2123
dev_dependencies:
2224
flutter_driver:
2325
sdk: flutter
24-
26+
flutter_test:
27+
sdk: flutter
2528
integration_test:
2629
sdk: flutter
2730

packages/in_app_purchase/in_app_purchase_android/example/pubspec.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ dependencies:
2222
dev_dependencies:
2323
flutter_driver:
2424
sdk: flutter
25+
flutter_test:
26+
sdk: flutter
2527
integration_test:
2628
sdk: flutter
2729

packages/in_app_purchase/in_app_purchase_storekit/example/pubspec.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ dependencies:
2222
dev_dependencies:
2323
flutter_driver:
2424
sdk: flutter
25+
flutter_test:
26+
sdk: flutter
2527
integration_test:
2628
sdk: flutter
2729

packages/ios_platform_images/example/pubspec.yaml

+4-4
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,6 @@ dependencies:
1010
cupertino_icons: ^1.0.2
1111
flutter:
1212
sdk: flutter
13-
14-
dev_dependencies:
15-
flutter_test:
16-
sdk: flutter
1713
ios_platform_images:
1814
# When depending on this package from a real application you should use:
1915
# ios_platform_images: ^x.y.z
@@ -22,5 +18,9 @@ dev_dependencies:
2218
# the parent directory to use the current plugin's version.
2319
path: ../
2420

21+
dev_dependencies:
22+
flutter_test:
23+
sdk: flutter
24+
2525
flutter:
2626
uses-material-design: true

packages/local_auth/local_auth/example/pubspec.yaml

+4
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,15 @@ dependencies:
1616
# The example app is bundled with the plugin so we use a path dependency on
1717
# the parent directory to use the current plugin's version.
1818
path: ../
19+
local_auth_android: ^1.0.0
20+
local_auth_ios: ^1.0.1
1921

2022
dev_dependencies:
2123
build_runner: ^2.1.10
2224
flutter_driver:
2325
sdk: flutter
26+
flutter_test:
27+
sdk: flutter
2428
integration_test:
2529
sdk: flutter
2630

packages/local_auth/local_auth_android/example/pubspec.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ dependencies:
2121
dev_dependencies:
2222
flutter_driver:
2323
sdk: flutter
24+
flutter_test:
25+
sdk: flutter
2426
integration_test:
2527
sdk: flutter
2628

packages/local_auth/local_auth_ios/example/pubspec.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ dependencies:
2121
dev_dependencies:
2222
flutter_driver:
2323
sdk: flutter
24+
flutter_test:
25+
sdk: flutter
2426
integration_test:
2527
sdk: flutter
2628

packages/local_auth/local_auth_windows/example/pubspec.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ dependencies:
2121
dev_dependencies:
2222
flutter_driver:
2323
sdk: flutter
24+
flutter_test:
25+
sdk: flutter
2426
integration_test:
2527
sdk: flutter
2628

packages/path_provider/path_provider/example/pubspec.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ dependencies:
2020
dev_dependencies:
2121
flutter_driver:
2222
sdk: flutter
23+
flutter_test:
24+
sdk: flutter
2325
integration_test:
2426
sdk: flutter
2527

packages/path_provider/path_provider_android/example/pubspec.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ dependencies:
2121
dev_dependencies:
2222
flutter_driver:
2323
sdk: flutter
24+
flutter_test:
25+
sdk: flutter
2426
integration_test:
2527
sdk: flutter
2628

packages/path_provider/path_provider_ios/example/pubspec.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ dependencies:
2121
dev_dependencies:
2222
flutter_driver:
2323
sdk: flutter
24+
flutter_test:
25+
sdk: flutter
2426
integration_test:
2527
sdk: flutter
2628

packages/path_provider/path_provider_macos/example/pubspec.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ dependencies:
2121
dev_dependencies:
2222
flutter_driver:
2323
sdk: flutter
24+
flutter_test:
25+
sdk: flutter
2426
integration_test:
2527
sdk: flutter
2628

packages/path_provider/path_provider_windows/example/pubspec.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ dependencies:
2020
dev_dependencies:
2121
flutter_driver:
2222
sdk: flutter
23+
flutter_test:
24+
sdk: flutter
2325
integration_test:
2426
sdk: flutter
2527

packages/quick_actions/quick_actions/example/pubspec.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ dev_dependencies:
2121
espresso: ^0.1.0+2
2222
flutter_driver:
2323
sdk: flutter
24+
flutter_test:
25+
sdk: flutter
2426
integration_test:
2527
sdk: flutter
2628

packages/quick_actions/quick_actions_android/example/pubspec.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ dev_dependencies:
2121
espresso: ^0.1.0+2
2222
flutter_driver:
2323
sdk: flutter
24+
flutter_test:
25+
sdk: flutter
2426
integration_test:
2527
sdk: flutter
2628

packages/quick_actions/quick_actions_ios/example/pubspec.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ dependencies:
2020
dev_dependencies:
2121
flutter_driver:
2222
sdk: flutter
23+
flutter_test:
24+
sdk: flutter
2325
integration_test:
2426
sdk: flutter
2527

packages/shared_preferences/shared_preferences/example/pubspec.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ dependencies:
2020
dev_dependencies:
2121
flutter_driver:
2222
sdk: flutter
23+
flutter_test:
24+
sdk: flutter
2325
integration_test:
2426
sdk: flutter
2527

packages/shared_preferences/shared_preferences_android/example/pubspec.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ dependencies:
2121
dev_dependencies:
2222
flutter_driver:
2323
sdk: flutter
24+
flutter_test:
25+
sdk: flutter
2426
integration_test:
2527
sdk: flutter
2628

packages/shared_preferences/shared_preferences_ios/example/pubspec.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ dependencies:
2121
dev_dependencies:
2222
flutter_driver:
2323
sdk: flutter
24+
flutter_test:
25+
sdk: flutter
2426
integration_test:
2527
sdk: flutter
2628

packages/shared_preferences/shared_preferences_linux/example/pubspec.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ dependencies:
2020
dev_dependencies:
2121
flutter_driver:
2222
sdk: flutter
23+
flutter_test:
24+
sdk: flutter
2325
integration_test:
2426
sdk: flutter
2527

0 commit comments

Comments
 (0)