From cecf6cc8304bf584cb884e134f743d26acb730b5 Mon Sep 17 00:00:00 2001 From: Aaron Date: Fri, 20 Sep 2024 22:53:04 -0500 Subject: [PATCH 1/5] Debug --- .github/workflows/build-platforms.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-platforms.yml b/.github/workflows/build-platforms.yml index 3df61fe..4b17f72 100644 --- a/.github/workflows/build-platforms.yml +++ b/.github/workflows/build-platforms.yml @@ -48,6 +48,7 @@ jobs: for binary in bun bunv bunx; do codesign --force --options runtime --sign "${{ secrets.APPLE_CERT_NAME }}" "$binary" done + ls -lA echo "Notarizing..." ditto -c -k --keepParent . binaries.zip @@ -58,7 +59,8 @@ jobs: echo "Stapling..." for binary in bun bunv bunx; do - xcrun stapler staple "$binary" + codesign --verify --verbose "$binary" + xcrun stapler staple -v "$binary" done - uses: vimtor/action-zip@v1.2 From 071ac7bb514731a13d8471fbf544d14fc3f0242d Mon Sep 17 00:00:00 2001 From: Aaron Date: Fri, 20 Sep 2024 23:07:49 -0500 Subject: [PATCH 2/5] Don't staple? --- .github/workflows/build-platforms.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build-platforms.yml b/.github/workflows/build-platforms.yml index 4b17f72..a58d46c 100644 --- a/.github/workflows/build-platforms.yml +++ b/.github/workflows/build-platforms.yml @@ -57,11 +57,11 @@ jobs: --team-id "${{ secrets.APPLE_TEAM_ID }}" \ --password "${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}" - echo "Stapling..." - for binary in bun bunv bunx; do - codesign --verify --verbose "$binary" - xcrun stapler staple -v "$binary" - done + # echo "Stapling..." + # for binary in bun bunv bunx; do + # codesign --verify --verbose "$binary" + # xcrun stapler staple -v "$binary" + # done - uses: vimtor/action-zip@v1.2 with: From 18247ad9308f2643862601a05549793479bd3d81 Mon Sep 17 00:00:00 2001 From: Aaron Date: Fri, 20 Sep 2024 23:20:58 -0500 Subject: [PATCH 3/5] Don't notarize? --- .github/workflows/build-platforms.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build-platforms.yml b/.github/workflows/build-platforms.yml index a58d46c..e5d71c3 100644 --- a/.github/workflows/build-platforms.yml +++ b/.github/workflows/build-platforms.yml @@ -50,12 +50,12 @@ jobs: done ls -lA - echo "Notarizing..." - ditto -c -k --keepParent . binaries.zip - xcrun notarytool submit binaries.zip --wait \ - --apple-id "${{ secrets.APPLE_ID }}" \ - --team-id "${{ secrets.APPLE_TEAM_ID }}" \ - --password "${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}" + # echo "Notarizing..." + # ditto -c -k --keepParent . binaries.zip + # xcrun notarytool submit binaries.zip --wait \ + # --apple-id "${{ secrets.APPLE_ID }}" \ + # --team-id "${{ secrets.APPLE_TEAM_ID }}" \ + # --password "${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}" # echo "Stapling..." # for binary in bun bunv bunx; do From d52e930554ee77c40f9151898bae9f9ba21aaeb1 Mon Sep 17 00:00:00 2001 From: Aaron Date: Fri, 20 Sep 2024 23:24:39 -0500 Subject: [PATCH 4/5] Add notarize back --- .github/workflows/build-platforms.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build-platforms.yml b/.github/workflows/build-platforms.yml index e5d71c3..a58d46c 100644 --- a/.github/workflows/build-platforms.yml +++ b/.github/workflows/build-platforms.yml @@ -50,12 +50,12 @@ jobs: done ls -lA - # echo "Notarizing..." - # ditto -c -k --keepParent . binaries.zip - # xcrun notarytool submit binaries.zip --wait \ - # --apple-id "${{ secrets.APPLE_ID }}" \ - # --team-id "${{ secrets.APPLE_TEAM_ID }}" \ - # --password "${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}" + echo "Notarizing..." + ditto -c -k --keepParent . binaries.zip + xcrun notarytool submit binaries.zip --wait \ + --apple-id "${{ secrets.APPLE_ID }}" \ + --team-id "${{ secrets.APPLE_TEAM_ID }}" \ + --password "${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}" # echo "Stapling..." # for binary in bun bunv bunx; do From 45bb3de10ff8b13cc24c53a5c97c83282745188d Mon Sep 17 00:00:00 2001 From: Aaron Date: Fri, 20 Sep 2024 23:30:15 -0500 Subject: [PATCH 5/5] Cleanup --- .github/workflows/build-platforms.yml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.github/workflows/build-platforms.yml b/.github/workflows/build-platforms.yml index a58d46c..b06a065 100644 --- a/.github/workflows/build-platforms.yml +++ b/.github/workflows/build-platforms.yml @@ -48,7 +48,6 @@ jobs: for binary in bun bunv bunx; do codesign --force --options runtime --sign "${{ secrets.APPLE_CERT_NAME }}" "$binary" done - ls -lA echo "Notarizing..." ditto -c -k --keepParent . binaries.zip @@ -57,12 +56,6 @@ jobs: --team-id "${{ secrets.APPLE_TEAM_ID }}" \ --password "${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}" - # echo "Stapling..." - # for binary in bun bunv bunx; do - # codesign --verify --verbose "$binary" - # xcrun stapler staple -v "$binary" - # done - - uses: vimtor/action-zip@v1.2 with: files: zig-out/bin/bun zig-out/bin/bunx zig-out/bin/bunv