remove unused parameters

Author: afragen

CHANGES.md

@@ -6,6 +6,7 @@
 * update `printf()` in `class Branches`
 * fix old `git-updater-pro` and `git-updater-additions` textdomains
 * update `Base::upgrader_source_selection()` when trying to update `$source` and `$new_source` when destination directories are identical
+* remove unused parameters in certain functions
 
 #### 12.4.0 / 2024-03-04
 * update `freemius/wordpress-sdk`

git-updater.php

@@ -12,7 +12,7 @@
  * Plugin Name:       Git Updater
  * Plugin URI:        https://git-updater.com
  * Description:       A plugin to automatically update GitHub hosted plugins, themes, and language packs. Additional API plugins available for Bitbucket, GitLab, Gitea, and Gist.
- * Version:           12.4.0.6
+ * Version:           12.4.0.7
  * Author:            Andy Fragen
  * License:           MIT
  * Domain Path:       /languages

src/Git_Updater/Base.php

@@ -508,13 +508,13 @@ public function upgrader_source_selection( $source, $remote_source, $upgrader, $
 
 		if ( trailingslashit( strtolower( $source ) ) !== trailingslashit( strtolower( $new_source ) ) ) {
 			$result = move_dir( $source, $new_source, true );
-			if ( \is_wp_error( $result ) ) {
+			if ( is_wp_error( $result ) ) {
 				return $result;
 			}
 		}
 
 		// Clean up $new_source directory.
-		add_action( 'upgrader_install_package_result', [ $this, 'delete_upgrade_source' ], 10, 2 );
+		add_action( 'upgrader_install_package_result', [ $this, 'delete_upgrade_source' ], 10, 1 );
 
 		return trailingslashit( $new_source );
 	}

src/Git_Updater/Branch.php

@@ -205,12 +205,11 @@ public function set_branch_on_install( $install ) {
 	/**
 	 * Add branch switch row to plugins page.
 	 *
-	 * @param string    $plugin_file Plugin file.
-	 * @param \stdClass $plugin_data Plugin repo data.
+	 * @param string $plugin_file Plugin file.
 	 *
 	 * @return bool
 	 */
-	public function plugin_branch_switcher( $plugin_file, $plugin_data ) {
+	public function plugin_branch_switcher( $plugin_file ) {
 		if ( empty( self::$options['branch_switch'] ) ) {
 			return false;
 		}
@@ -260,11 +259,10 @@ public function plugin_branch_switcher( $plugin_file, $plugin_data ) {
 	 * Create branch switcher row for theme multisite installation.
 	 *
 	 * @param string $theme_key Theme slug.
-	 * @param array  $theme     Array of theme data.
 	 *
 	 * @return bool
 	 */
-	public function multisite_branch_switcher( $theme_key, $theme ) {
+	public function multisite_branch_switcher( $theme_key ) {
 		if ( empty( self::$options['branch_switch'] ) ) {
 			return false;
 		}

src/Git_Updater/Install.php

@@ -291,7 +291,7 @@ private function get_upgrader( $type, $url ) {
 					'install_theme_complete_actions',
 				],
 				10,
-				3
+				1
 			);
 		}
 
@@ -454,12 +454,10 @@ public function install_api() {
 	 * Fix activation links after theme installation, no method to get proper theme name.
 	 *
 	 * @param array $install_actions Array of theme actions.
-	 * @param mixed $api             Unused.
-	 * @param mixed $theme_info      Theme slug.
 	 *
 	 * @return mixed
 	 */
-	public function install_theme_complete_actions( $install_actions, $api, $theme_info ) {
+	public function install_theme_complete_actions( $install_actions ) {
 		if ( isset( $install_actions['preview'] ) ) {
 			unset( $install_actions['preview'] );
 		}

src/Git_Updater/Plugin.php

@@ -292,7 +292,7 @@ public function get_remote_plugin_meta() {
 			if ( 'init' === current_filter()
 				&& ( ! is_multisite() || is_network_admin() )
 			) {
-				add_action( "after_plugin_row_{$plugin->file}", [ new Branch(), 'plugin_branch_switcher' ], 15, 3 );
+				add_action( "after_plugin_row_{$plugin->file}", [ new Branch(), 'plugin_branch_switcher' ], 15, 1 );
 			}
 		}
 

src/Git_Updater/Theme.php

@@ -254,10 +254,10 @@ public function get_remote_theme_meta() {
 			 * Add update row to theme row, only in multisite.
 			 */
 			if ( is_multisite() ) {
-				add_action( 'after_theme_row', [ $this, 'remove_after_theme_row' ], 10, 2 );
+				add_action( 'after_theme_row', [ $this, 'remove_after_theme_row' ], 10, 1 );
 				if ( ! $this->tag ) {
 					add_action( "after_theme_row_{$theme->slug}", [ $this, 'wp_theme_update_row' ], 10, 2 );
-					add_action( "after_theme_row_{$theme->slug}", [ new Branch(), 'multisite_branch_switcher' ], 15, 2 );
+					add_action( "after_theme_row_{$theme->slug}", [ new Branch(), 'multisite_branch_switcher' ], 15, 1 );
 				}
 			}
 		}
@@ -426,9 +426,8 @@ public function wp_theme_update_row( $theme_key, $theme ) {
 	 * @author @grappler
 	 *
 	 * @param string $theme_key Theme slug.
-	 * @param array  $theme     Array of theme data.
 	 */
-	public function remove_after_theme_row( $theme_key, $theme ) {
+	public function remove_after_theme_row( $theme_key ) {
 		$themes = $this->get_theme_configs();
 
 		if ( array_key_exists( $theme_key, $themes ) ) {

src/Git_Updater/Traits/GU_Trait.php

@@ -817,11 +817,11 @@ final protected function get_repo_requirements( $repo ) {
 	 *
 	 * @global WP_Filesystem_Base $wp_filesystem WordPress filesystem subclass.
 	 *
-	 * @param array|WP_Error $result     Result from WP_Upgrader::install_package().
-	 * @param array          $hook_extra Extra arguments passed to hooked filters.
+	 * @param array|WP_Error $result Result from WP_Upgrader::install_package().
+
 	 * @return bool
 	 */
-	final public function delete_upgrade_source( $result, $hook_extra ) {
+	final public function delete_upgrade_source( $result ) {
 		global $wp_filesystem;
 
 		if ( ! is_wp_error( $result ) && ! empty( $result['destination_name'] ) ) {