Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Alert Dialog component #3512

Closed
Rajdeepc opened this issue Aug 4, 2023 · 0 comments · Fixed by #3501
Closed

Create Alert Dialog component #3512

Rajdeepc opened this issue Aug 4, 2023 · 0 comments · Fixed by #3501
Assignees
Labels

Comments

@Rajdeepc
Copy link
Contributor

Rajdeepc commented Aug 4, 2023

Spectrum CSS PR

adobe/spectrum-css#1862

Acceptance Criteria

  • Create an RFC that discusses what needs to be built, what affects it'll have, how folks will migrate, etc
  • Review RFC with team
  • Upon consensus create/convert ticket(s) needed to build the component
  • Add storybook and Unit Tests

What needs to be built?

New Alert-dialog component in SWC.
https://pr-1862--spectrum-css.netlify.app/alertdialog

What effects it'll have?

New Alert Dialog Component

How to migrate?

  1. Adding the new package in tsconfig-all.json
  2. Updating alert-dialog/tsconfig.json to import shared and base config
  3. Adding button and icon dependencies
  4. To make sure we have something like :host[variant='confirmation'] etc. we need to add a property in spectrum-config.ts to update the spectrum generated css file to create css classnames like above.
@Rajdeepc Rajdeepc self-assigned this Aug 4, 2023
@Rajdeepc Rajdeepc added the WIP label Aug 4, 2023
@Rajdeepc Rajdeepc linked a pull request Aug 7, 2023 that will close this issue
13 tasks
@jnjosh jnjosh changed the title [Spike] Create RFC/ARD for Alert Dialog component Create RFC/ARD for Alert Dialog component Aug 10, 2023
@jnjosh jnjosh changed the title Create RFC/ARD for Alert Dialog component Create Alert Dialog component Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant