Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add Support for seo tags as in Wcm Core #58

Open
nhirrle opened this issue Sep 26, 2022 · 0 comments
Open

[feature] Add Support for seo tags as in Wcm Core #58

nhirrle opened this issue Sep 26, 2022 · 0 comments

Comments

@nhirrle
Copy link

nhirrle commented Sep 26, 2022

Is your feature request related to a problem? Please describe.
Add Support for getRobotsTags as in Wcm Core. Currently method is not implemented in https://github.com/adobe/aem-spa-project-core/blob/master/core/src/main/java/com/adobe/aem/spa/project/core/internal/impl/PageImpl.java and therfor the default implementation is used in https://github.com/adobe/aem-core-wcm-components/blob/main/bundles/core/src/main/java/com/adobe/cq/wcm/core/components/models/Page.java#L450-L452 .

Describe the solution you'd like
Core components have the implementation here https://github.com/adobe/aem-core-wcm-components/blob/main/bundles/core/src/main/java/com/adobe/cq/wcm/core/components/internal/models/v2/PageImpl.java#L385-L397 , but actually we can just use delegation pattern.

Describe alternatives you've considered
None, we had to overwrite it in the client project

Additional context
N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant