diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md index 586b2f34..50ee6ced 100644 --- a/RELEASE-NOTES.md +++ b/RELEASE-NOTES.md @@ -37,6 +37,7 @@ Project Page: https://github.com/a2stuff/a2d * Fix clipping bug when icon is underneath aligned right edges of two windows. * Fix clipping bug when icon's middle is obscured by overlapping windows. * Improve adding/editing shortcuts for volumes. ([#831](https://github.com/a2stuff/a2d/issues/831)) +* Enable File > Copy To... for volume icons. ([#830](https://github.com/a2stuff/a2d/issues/830)) ### Selector diff --git a/desktop/auxmem.s b/desktop/auxmem.s index 37137c9a..b774345c 100644 --- a/desktop/auxmem.s +++ b/desktop/auxmem.s @@ -173,7 +173,7 @@ file_menu: kMenuItemIdRenameIcon = 7 kMenuItemIdDuplicate = 8 ;; -------------------- - kMenuItemIdCopyFile = 10 + kMenuItemIdCopySelection = 10 kMenuItemIdDeleteFile = 11 ;; -------------------- kMenuItemIdQuit = 13 diff --git a/desktop/main.s b/desktop/main.s index 42371b1e..a67ccdb2 100644 --- a/desktop/main.s +++ b/desktop/main.s @@ -1277,6 +1277,7 @@ disable:ldy #MGTK::disableitem_disable table: .byte kMenuIdFile, aux::kMenuItemIdOpen .byte kMenuIdFile, aux::kMenuItemIdGetInfo + .byte kMenuIdFile, aux::kMenuItemIdCopySelection .byte 0 .endproc ; _ToggleMenuItemsRequiringSelection _EnableMenuItemsRequiringSelection := _ToggleMenuItemsRequiringSelection::enable @@ -1313,7 +1314,6 @@ disable:ldy #MGTK::disableitem_disable param_jump _ToggleMenuItems, table table: - .byte kMenuIdFile, aux::kMenuItemIdCopyFile .byte kMenuIdFile, aux::kMenuItemIdDeleteFile .byte 0 .endproc ; _ToggleMenuItemsRequiringFileSelection diff --git a/res/notes/testplan.md b/res/notes/testplan.md index 843874a1..d43abe53 100644 --- a/res/notes/testplan.md +++ b/res/notes/testplan.md @@ -120,38 +120,52 @@ * Launch DeskTop. Clear the selection (e.g. by clicking on the DeskTop). Verify that: * Special > Eject Disk and Special > Check Drive are disabled. * File > Duplicate and Special > Make Alias are disabled. - * File > Rename is disabled. - * File > Open and File > Get Info are disabled. + * File > Rename and Edit > Cut/Copy/Paste/Clear are disabled. + * File > Delete is disabled. + * File > Open, File > Get Info, and File > Copy To... are disabled. + * File > Duplicate and Special > Make Alias are disabled. * Launch DeskTop. Select only the Trash icon. Verify that: * Special > Eject Disk and Special > Check Drive are disabled. * File > Duplicate and Special > Make Alias are disabled. - * File > Rename is disabled. - * File > Open and File > Get Info are disabled. + * File > Rename and Edit > Cut/Copy/Paste/Clear are disabled. + * File > Delete is disabled. + * File > Open, File > Get Info, and File > Copy To... are disabled. + * File > Duplicate and Special > Make Alias are disabled. * Launch DeskTop. Select a volume. Verify that: * Special > Eject Disk and Special > Check Drive are enabled. * File > Duplicate and Special > Make Alias are disabled. - * File > Rename is enabled. - * File > Open and File > Get Info are enabled. + * File > Rename and Edit > Cut/Copy/Paste/Clear are enabled. + * File > Delete is disabled. + * File > Open, File > Get Info, and File > Copy To... are enabled. + * File > Duplicate and Special > Make Alias are disabled. * Launch DeskTop. Select two volume icons. Verify that: * Special > Eject Disk and Special > Check Drive are enabled. * File > Duplicate and Special > Make Alias are disabled. - * File > Rename is disabled. - * File > Open and File > Get Info are enabled. + * File > Rename and Edit > Cut/Copy/Paste/Clear are disabled. + * File > Delete is disabled. + * File > Open, File > Get Info, and File > Copy To... are enabled. + * File > Duplicate and Special > Make Alias are disabled. * Launch DeskTop. Select a volume icon and the Trash icon. Verify that: * Special > Eject Disk and Special > Check Drive are enabled. * File > Duplicate and Special > Make Alias are disabled. - * File > Rename is disabled. - * File > Open and File > Get Info are enabled. -* Launch DeskTop. Open a volume window, and select a file. Verify that: + * File > Rename and Edit > Cut/Copy/Paste/Clear are disabled. + * File > Delete is disabled. + * File > Open, File > Get Info, and File > Copy To... are enabled. + * File > Duplicate and Special > Make Alias are disabled. +* Launch DeskTop. Open a volume window, and select a single file. Verify that: * Special > Eject Disk and Special > Check Drive are disabled. * File > Duplicate and Special > Make Alias are enabled. - * File > Rename is enabled. - * File > Open and File > Get Info are enabled. + * File > Rename and Edit > Cut/Copy/Paste/Clear are enabled. + * File > Delete is enabled. + * File > Open, File > Get Info, and File > Copy To... are enabled. + * File > Duplicate and Special > Make Alias are enabled. * Launch DeskTop. Open a volume window, and select two files. Verify that: * Special > Eject Disk and Special > Check Drive are disabled. * File > Duplicate and Special > Make Alias are disabled. - * File > Rename is disabled. - * File > Open and File > Get Info are enabled. + * File > Rename and Edit > Cut/Copy/Paste/Clear are disabled. + * File > Delete is enabled. + * File > Open, File > Get Info, and File > Copy To... are enabled. + * File > Duplicate and Special > Make Alias are disabled. * Launch DeskTop. Close all windows. Verify that File > New Folder, File > Close, File > Close All, and everything in the View menu are disabled. * Launch DeskTop. Open a window. Verify that File > New Folder, File > Close, File > Close All, and everything in the View menu are enabled. * Launch DeskTop. Open a window for a removable disk. Quit DeskTop. Remove the disk. Restart DeskTop. Open a different volume's window. Close it. Open it again. Verify that items in the File menu needing a window (New Folder, Close, etc) are correctly enabled.