Skip to content

Latest commit

 

History

History
52 lines (37 loc) · 2.56 KB

PULL_REQUEST_TEMPLATE.md

File metadata and controls

52 lines (37 loc) · 2.56 KB

Issue description

Explain the issue that the changes in the pull request solve.

Steps to test the changes

Include steps to test or reproduce (in case of a bugfix) the changes in the pull request. This section should help the reviewer verify your changes.

Solution description

Briefly explain the solution or add a link to the technical design document (this will help the reviewer confirm the code does what you intend). Feel free to also mention alternative approaches that didn't work out.

Sanity checklist

  • I have clicked through the app to make sure my changes work and not break the app.
  • I have applied the correct milestone and labels.
  • My changes fix the issue described in the description (and do nothing else). 🤞
  • My changes are covered by tests.
  • My changes follow our performance guidelines.
  • My changes follow our js and/or python guidelines.
  • My commits follow our commit guidelines.

PR Review checklist

  • The changes fix the issue and don't cause any apparent regressions.
  • Labels and milestone are correctly set.
  • The solution description matches the changes in the code.
  • There is no apparent way to improve the performance & design of the new code.
  • The pull request is opened against the correct base branch.
  • Upon merging, the Jira ticket's fixversion is correctly set and the ticket is moved to "QA - In Progress".