Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Instrumentation logging #28

Open
1 task
klemie opened this issue Sep 27, 2024 · 2 comments
Open
1 task

Split Instrumentation logging #28

klemie opened this issue Sep 27, 2024 · 2 comments
Assignees

Comments

@klemie
Copy link
Member

klemie commented Sep 27, 2024

Description

During test we need to split log files at 15 minute increments. Mainly just incase the file corrupts we have backups. also just easier to work with.

Acceptance Criteria

  • Instrumentation logging splits at 15min intervals or ___ storage size

QA Notes

Linked issues

@klemie klemie added this to the Oct 2024 Cold Flow milestone Sep 27, 2024
@jjderooy
Copy link
Contributor

jjderooy commented Oct 3, 2024

Implemented in split-data-files. I thought that splitting every 100000 lines was pretty reasonable but we can change that if we want. I can make a PR if it sounds good.

@jjderooy jjderooy self-assigned this Oct 3, 2024
@klemie
Copy link
Member Author

klemie commented Oct 3, 2024

Implemented in split-data-files. I thought that splitting every 100000 lines was pretty reasonable but we can change that if we want. I can make a PR if it sounds good.

Do it, I dare you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants