Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis fails on Electron builds using Node 12.x #1197

Closed
pdesantis opened this issue Jul 30, 2019 · 3 comments
Closed

Travis fails on Electron builds using Node 12.x #1197

pdesantis opened this issue Jul 30, 2019 · 3 comments

Comments

@pdesantis
Copy link
Contributor

The error is:

Error: No test files found
The command "if [[ "${NODE_VERSION}" ]]; then if [[ "${ELECTRON_VERSION}" ]]; then ./scripts/build_against_electron.sh; else ./scripts/build_against_node.sh; fi; fi" exited with 1.

This seems to affect all new PRs, such as #1192 & #1195

Here is a failing Travis job: https://travis-ci.org/mapbox/node-sqlite3/jobs/565236851
@pdesantis pdesantis mentioned this issue Jul 30, 2019
Merged
@kewde
Copy link
Collaborator

kewde commented Aug 3, 2019

Thank you for reporting the issue, I am resolving this.

@kewde
Copy link
Collaborator

kewde commented Aug 3, 2019

c61ab02

@kewde
Copy link
Collaborator

kewde commented Aug 3, 2019

Solved in #1195

@kewde kewde closed this as completed Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pdesantis @kewde