Skip to content

Commit 212f4aa

Browse files
authored
feat(node): add initial node v12 support & update min versions (#1003)
- update minimum versions of node 8 & 10 to latest security patches - add node v12 to supported versions & travis testing (note: allow_failures is set because no public version of Ghost supports node 12 yet)
1 parent e0bcbae commit 212f4aa

File tree

2 files changed

+17
-7
lines changed

2 files changed

+17
-7
lines changed

.travis.yml

+16-6
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,31 @@
11
dist: xenial
22
language: node_js
33
node_js:
4-
- 8
5-
- 10
4+
- 8
5+
- 10
66

77
cache: yarn
88

99
jobs:
1010
include:
11-
- node_js: "10"
11+
- node_js: '10'
1212
env: TEST_SUITE=lint
13+
- node_js: '12'
14+
allow_failures:
15+
- node_js: '12'
1316

1417
# Don't run builds for renovate PRs
1518
if: NOT head_branch =~ ^renovate
1619

17-
script:
18-
- if [ "$TEST_SUITE" == "lint" ]; then yarn run lint; else yarn run test:all; fi
20+
script: |
21+
if [ "$TEST_SUITE" == "lint" ]; then
22+
yarn lint
23+
elif [ "$TRAVIS_NODE_VERSION" == "12" ]; then
24+
yarn test:unit
25+
GHOST_NODE_VERSION_CHECK=false yarn test:acceptance
26+
else
27+
yarn test:all
28+
fi
1929
2030
after_success:
21-
- if [[ "$TRAVIS_NODE_VERSION" == "10" && "$TEST_SUITE" != "lint" ]]; then yarn run coverage; fi
31+
- if [[ "$TRAVIS_NODE_VERSION" == "10" && "$TEST_SUITE" != "lint" ]]; then yarn coverage; fi

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
]
4343
},
4444
"engines": {
45-
"node": "^8.10.0 || ^10.13.0"
45+
"node": "^8.16.0 || ^10.16.0 || ^12.11.0"
4646
},
4747
"preferGlobal": true,
4848
"dependencies": {

0 commit comments

Comments
 (0)