From 3951b004e5bf7ad2f6af2b119823301aa6ef11be Mon Sep 17 00:00:00 2001 From: Ken Dale Date: Thu, 24 Apr 2014 10:52:05 -0400 Subject: [PATCH] Fix GetMultipleTickets(Async) throwing 400 Bad Request for single ticket id --- Tests/TicketTests.cs | 27 +++++++++++++++++++++++++++ ZendeskApi_v2/Requests/Tickets.cs | 4 ++-- 2 files changed, 29 insertions(+), 2 deletions(-) diff --git a/Tests/TicketTests.cs b/Tests/TicketTests.cs index 9e27068d..c3ae57e7 100644 --- a/Tests/TicketTests.cs +++ b/Tests/TicketTests.cs @@ -111,6 +111,33 @@ public void CanGetMultipleTickets() Assert.AreEqual(tickets.Count, ids.Count); } + [Test] + public async Task CanGetMultipleTicketsAsync() + { + var ids = new List() { Settings.SampleTicketId, Settings.SampleTicketId2 }; + var tickets = await api.Tickets.GetMultipleTicketsAsync(ids); + Assert.NotNull(tickets); + Assert.AreEqual(tickets.Count, ids.Count); + } + + [Test] + public void CanGetMultipleTicketsSingleTicket() + { + var ids = new List() { Settings.SampleTicketId }; + var tickets = api.Tickets.GetMultipleTickets(ids); + Assert.NotNull(tickets); + Assert.AreEqual(tickets.Count, ids.Count); + } + + [Test] + public async Task CanGetMultipleTicketsAsyncSingleTicket() + { + var ids = new List() { Settings.SampleTicketId }; + var tickets = await api.Tickets.GetMultipleTicketsAsync(ids); + Assert.NotNull(tickets); + Assert.AreEqual(tickets.Count, ids.Count); + } + [Test] public void CorrectErrorMessagesAreThrown() { diff --git a/ZendeskApi_v2/Requests/Tickets.cs b/ZendeskApi_v2/Requests/Tickets.cs index bed2db8c..9d1f74e4 100644 --- a/ZendeskApi_v2/Requests/Tickets.cs +++ b/ZendeskApi_v2/Requests/Tickets.cs @@ -111,7 +111,7 @@ public GroupCommentResponse GetTicketComments(long ticketId) public GroupTicketResponse GetMultipleTickets(List ids) { - return GenericGet(string.Format("{0}/show_many?ids={1}.json", _tickets, ids.ToCsv())); + return GenericGet(string.Format("{0}/show_many.json?ids={1}", _tickets, ids.ToCsv())); } public IndividualTicketResponse CreateTicket(Ticket ticket) @@ -326,7 +326,7 @@ public async Task GetTicketCommentsAsync(long ticketId) public async Task GetMultipleTicketsAsync(List ids) { - return await GenericGetAsync(string.Format("{0}/show_many?ids={1}.json", _tickets, ids.ToCsv())); + return await GenericGetAsync(string.Format("{0}/show_many.json?ids={1}", _tickets, ids.ToCsv())); } public async Task CreateTicketAsync(Ticket ticket)