[Regression][develop] Expand-ZipArchive cannot remove already removed archive

[Ash258]

Cause:
https://github.com/lukesampson/scoop/blob/f5fdc275ca27166c7fd862932f4ad2e124708f20/lib/decompress.ps1#L238-L246

If there is extract_dir property set, archive is deleted twice.

first in gci -exclude $ExtractDir | Remove
then in if ($Removal)

/cc @niheaven

[niheaven]

Yes, fixed in #3472 😂

Expand-ZipArchive and Expand-MsiArchive are fixed.

[Ash258]

Why so complicated? You could just add gci . -Exlude $ExtractDir, $Path or not?

[niheaven]

I try to do so in #3470, and in fact, gci . -Exclude $ExtractDir, (SplitPath $Path -Leaf) works.

But this failed when extract_dir has sub-dir, i.e. PFiles\Calibre2 for calibre-normal. -Exclude will not recognize sub dir, and Get-ChildItem or Remove-Item will remove PFiles.

Then I tried (Get-ChildItem . -Recurse).FullName -notmath '[Regex]::Escape($DestinationPath\$ExtractDir)|[Regex]::Escape($Path)' | Remove-Item and this will protect ExtractDir and Path, but it will remove other files if manifest has multi-url and multi-extract_dir (e.g. pkg-config).

So finanlly I choose to use _tmp dir for Expand-ZipArchive and Expand-MsiArchive.

For PowerShell Core, Expand-Archive has param -PassThru that return extracted files, and this will be helpful for filtering files, but PS 5 hasn't any output. Maybe ZipArchive.GetEntry and ZipFileExtensions.ExtractToFile will be helpful for rewriting Expand-Archive function with ExtractDir.