Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell does not appear on search #261

Closed
wodim opened this issue Dec 30, 2020 · 8 comments
Closed

Spell does not appear on search #261

wodim opened this issue Dec 30, 2020 · 8 comments
Labels
Bug i broke something TrinityCore issues related to the instance maintained by TrinityCore (https://aowow.trinitycore.info)

Comments

@wodim
Copy link
Contributor

wodim commented Dec 30, 2020

https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?spell=61332 does not appear in https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?search=dalaran+brilliance

@wodim
Copy link
Contributor Author

wodim commented Jan 20, 2021

@Jinnaix
Copy link

Jinnaix commented Jan 21, 2021

As far as i know, this is intended.
When i am logged into aowow as admin, i can search for your examples.
A simple user cant, because they have special hidden flags:

image

@wodim
Copy link
Contributor Author

wodim commented Jan 22, 2021

Seems like a fool's errand—most spells and a big chunk of NPCs should be flagged as "hidden", but they are not. Why leave such a half-assed system up?

@Jinnaix
Copy link

Jinnaix commented Jan 22, 2021

Well, better flag this stuff as hidden then - afterall, aowow is a user database. Triggers, serverside spells and stuff like that shouldnt be included in searches for users.

@Sarjuuk
Copy link
Owner

Sarjuuk commented Feb 15, 2021

Jinnaix got it.

though the tcubuntu instance is special and treats all users as devs. There seems to be some mishap when applying it to searches here.

@jackpoz
you'll probably need to amend

if (!User::isInGroup(U_GROUP_EMPLOYEE))
with the user groups you default to in
public static $groups = 0x0;

@Sarjuuk Sarjuuk added Bug i broke something TrinityCore issues related to the instance maintained by TrinityCore (https://aowow.trinitycore.info) labels Feb 15, 2021
@jackpoz
Copy link
Contributor

jackpoz commented Feb 16, 2021

actually that's not the case anymore. I'm currently running TrinityCore#41 without any other custom change and with auth db authentication enabled, so accounts created at https://tcubuntu.northeurope.cloudapp.azure.com/ can login.

See here how the same url gives different results (check the Abilities tab, it shows 18 on the left, 9 on the right) https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?search=holy+nova
image

@Sarjuuk
Copy link
Owner

Sarjuuk commented Feb 16, 2021

alright, not a bug then.

@Sarjuuk Sarjuuk closed this as completed Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug i broke something TrinityCore issues related to the instance maintained by TrinityCore (https://aowow.trinitycore.info)
Projects
None yet
Development

No branches or pull requests

4 participants