Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui5-message-strip]: No default theming for invalid color schemes #9457

Closed
1 task done
nikoletavnv opened this issue Jul 10, 2024 · 2 comments
Closed
1 task done

[ui5-message-strip]: No default theming for invalid color schemes #9457

nikoletavnv opened this issue Jul 10, 2024 · 2 comments
Labels

Comments

@nikoletavnv
Copy link
Member

Bug Description

When you set invalid number/value for the color-scheme property (e.g. 13), the appearance of the message strip does not default to an existing color scheme but looks strange, especially for design="ColorSet1" because there is white text on transparent background

Affected Component

No response

Expected Behaviour

No response

Isolated Example

No response

Steps to Reproduce

  1. Open https://sap.github.io/ui5-webcomponents/components/MessageStrip/
  2. Scroll to the sample "Custom visualisation"
  3. Edit the sample - set the following attributes to the second message strip:
    design="ColorSet1" color-scheme="13"
  4. No default theming for invalid color-scheme

Log Output, Stack Trace or Screenshots

No response

Priority

Low

UI5 Web Components Version

2.0.1

Browser

Chrome

Operating System

Windows

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@ilhan007
Copy link
Member

ilhan007 commented Jul 10, 2024

Previously there was a built-in mechanism in the framework for fallbacking to the default value when invalid one is set. With 2.0 this has been removed with this change

There are no fallbacks any more. All runtime checks for properties (especially enumerations) are removed. All type checking is left to the TypeScript compiler and assigning an invalid value to an enumeration or a number/boolean field is considered a bug that should be fixed instead of the framework silently masking it by providing a fallback value.

So I don't consider this as bug, if this happens we will ask the developer/consumer to fix the usage.
On CSS level probably we can write some smarter styles to make it better but again we will mask the wrong usage.

@ivoplashkov
Copy link
Member

Hi @ilhan007,

Thank you for your feedback regarding this issue. Since you mentioned that this isn't actually an issue, but more of an incorrect usage, I will go ahead and close it. If there are any further details or concerns related to this matter, please feel free to reopen the issue or create a new one.

Best regards,
Ivaylo

@github-project-automation github-project-automation bot moved this from New Issues to Completed in Maintenance - Topic RL Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

No branches or pull requests

3 participants