Skip to content

Commit 5eb5c3d

Browse files
authored
chore: revert ts moduleResoluition node16 to node (#7030)
Recently we [changed](#6981) our tsconfig to use Module Resolution ["node 16",](https://www.typescriptlang.org/tsconfig#moduleResolution) instead of "node" to get better ECMAScript Module Support: - 'node' for Node.js’ CommonJS implementation - 'node16' or 'nodenext' for Node.js’ ECMAScript Module Support [from TypeScript 4.7](https://devblogs.microsoft.com/typescript/announcing-typescript-4-7/#esm-nodejs) However, we faced issues on the application side. The TS compiler throws errors in Typescript applications that uses UI5 Web Components for files in applications' node_modules. More specifically, the problem was caused by new attribute "'resolution-mode'" added to the auto-generated .d.ts files that requires also tsconfig change by the project installed our code. ```sh Error: node_modules/@ui5/webcomponents/dist/DateComponentBase.d.ts:1:23 - error TS1452: 'resolution-mode' assertions are only supported when `moduleResolution` is `node16` or `nodenext`. /// <reference types="openui5" resolution-mode="require"/> ``` Although these errors can be handled with `skipLibCheck` flag set to "true", it's a bad experience to require a particular flag to just make an app working and we decided to revert this as it's seems the setting is not stable enough and can cause unexpected problems for consumers. Related to: #7020 (comment) Reverts: #6981
1 parent de89ea0 commit 5eb5c3d

File tree

8 files changed

+14
-16
lines changed

8 files changed

+14
-16
lines changed

packages/base/tsconfig.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
"sourceMap": true,
1010
"inlineSources": true,
1111
"strict": true,
12-
"module": "node16",
13-
"moduleResolution": "node16",
12+
"moduleResolution": "node",
1413
},
1514
}

packages/fiori/tsconfig.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@
99
"sourceMap": true,
1010
"inlineSources": true,
1111
"strict": true,
12-
"module": "node16",
13-
"moduleResolution": "node16",
12+
"moduleResolution": "node",
1413
"experimentalDecorators": true,
1514
},
1615
}

packages/icons-business-suite/tsconfig.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,9 @@
99
"sourceMap": true,
1010
"inlineSources": true,
1111
"strict": true,
12-
"module": "node16",
13-
"moduleResolution": "node16",
12+
"module": "es2022",
13+
"moduleResolution": "node",
1414
"resolveJsonModule": true,
15+
"allowSyntheticDefaultImports": true,
1516
},
1617
}

packages/icons-tnt/tsconfig.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,9 @@
99
"sourceMap": true,
1010
"inlineSources": true,
1111
"strict": true,
12-
"module": "node16",
13-
"moduleResolution": "node16",
12+
"module": "es2022",
13+
"moduleResolution": "node",
1414
"resolveJsonModule": true,
15+
"allowSyntheticDefaultImports": true,
1516
},
1617
}

packages/icons/tsconfig.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,9 @@
99
"sourceMap": true,
1010
"inlineSources": true,
1111
"strict": true,
12-
"module": "node16",
13-
"moduleResolution": "node16",
12+
"module": "es2022",
13+
"moduleResolution": "node",
1414
"resolveJsonModule": true,
15+
"allowSyntheticDefaultImports": true,
1516
},
1617
}

packages/localization/tsconfig.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
"sourceMap": true,
1010
"inlineSources": true,
1111
"strict": true,
12-
"module": "node16",
13-
"moduleResolution": "node16",
12+
"moduleResolution": "node",
1413
},
1514
}

packages/main/tsconfig.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@
99
"sourceMap": true,
1010
"inlineSources": true,
1111
"strict": true,
12-
"module": "node16",
13-
"moduleResolution": "node16",
12+
"moduleResolution": "node",
1413
"experimentalDecorators": true,
1514
},
1615
}

packages/theming/tsconfig.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@
99
"sourceMap": true,
1010
"inlineSources": true,
1111
"strict": true,
12-
"module": "node16",
13-
"moduleResolution": "node16",
12+
"moduleResolution": "node",
1413
"experimentalDecorators": true,
1514
},
1615
}

0 commit comments

Comments
 (0)