Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup TensorFlow environment #5350

Closed
tabergma opened this issue Mar 2, 2020 · 7 comments
Closed

Setup TensorFlow environment #5350

tabergma opened this issue Mar 2, 2020 · 7 comments
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/ml 👁 All issues related to machine learning type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@tabergma
Copy link
Contributor

tabergma commented Mar 2, 2020

In #5266 we discussed when and how to call tf_env.setup_tf_environment(). We should find a solution for users that call the train methods directly.

@tabergma tabergma added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Mar 2, 2020
@tabergma
Copy link
Contributor Author

@dakshvar22 Is this still relevant?

@dakshvar22
Copy link
Contributor

Probably yes, we haven't changed it since then.

@samsucik
Copy link
Contributor

@dakshvar22 sorry, I'm struggling to find the context for this one, could you perhaps briefly summarise? And what kind of users does this affect?

@dakshvar22
Copy link
Contributor

@samsucik tf_env.setup_tf_environment() is used to initialize CPU/GPU related environment variables of TF. We currently call this inside rasa/__main_.py. Hence, it works well when rasa open source is being invoked as a framework through the CLI or HTTP API. If a user tries to use it as a library where they try to write custom python code and pick bits and pieces of Rasa in their custom code, e.g. training an NLU model in a jupyter code, then depending on their code tensorflow environment may not configured correctly. So, this issue was about finding a more appropriate place inside the code to place it. I think it never got tackled because no one from the community really brought up an issue like that indicating that this may not be even needed.

@samsucik
Copy link
Contributor

@TyDunn what's your take on this? Do we wanna support use cases like those described by Daksh? cc @koaning because when I hear "training an NLU model in a jupyter code" I think of you 🧇

@TyDunn
Copy link
Contributor

TyDunn commented Jan 26, 2021

@samsucik Similar to what Daksh said above, I have not come across users who have brought this up. Does the research team find it to be valuable?

@alwx alwx added the area:rasa-oss/ml 👁 All issues related to machine learning label Jan 27, 2021
@rasabot-exalate rasabot-exalate added area:rasa-oss :ferris wheel: area:rasa-oss 🎡 Anything related to the open source Rasa framework and removed area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR area:rasa-oss/ml 👁 All issues related to machine learning area:rasa-oss :ferris wheel: labels Mar 17, 2022 — with Exalate Issue Sync
@m-vdb m-vdb added area:rasa-oss/ml 👁 All issues related to machine learning and removed area:rasa-oss/ml_👁 labels Mar 17, 2022
@rasabot-exalate rasabot-exalate added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR and removed type:enhancement_:sparkles: labels Mar 21, 2022 — with Exalate Issue Sync
@sync-by-unito
Copy link

sync-by-unito bot commented Dec 19, 2022

➤ Maxime Verger commented:

💡 Heads up! We're moving issues to Jira: https://rasa-open-source.atlassian.net/browse/OSS.

From now on, this Jira board is the place where you can browse (without an account) and create issues (you'll need a free Jira account for that). This GitHub issue has already been migrated to Jira and will be closed on January 9th, 2023. Do not forget to subscribe to the corresponding Jira issue!

➡️ More information in the forum: https://forum.rasa.com/t/migration-of-rasa-oss-issues-to-jira/56569.

@m-vdb m-vdb closed this as completed Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/ml 👁 All issues related to machine learning type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

No branches or pull requests

7 participants