-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add xnack to unified memory page #3732
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7cc8f4b
to
bb25693
Compare
neon60
approved these changes
Jan 29, 2025
MKKnorr
reviewed
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small suggestions
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
0498b4d
to
5931eb6
Compare
MKKnorr
reviewed
Jan 29, 2025
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
5931eb6
to
ed1171a
Compare
MKKnorr
approved these changes
Jan 29, 2025
randyh62
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments, but overall it looks good.
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
ed1171a
to
3d6df0d
Compare
3d6df0d
to
7decc13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sub-section about XNACK (along with a small example) to the
unified_memory.rst
page.