Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverse stupid decision to set a site-wide casing transform in formatUri #191

Closed
atruskie opened this issue Mar 16, 2015 · 1 comment
Closed

Reverse stupid decision to set a site-wide casing transform in formatUri #191

atruskie opened this issue Mar 16, 2015 · 1 comment
Labels
bug triage:medium

Comments

@atruskie
Copy link
Member

I thought it was a good idea at the time:

8069254

But it also means the default for the site means angular links aren't formatted appropriately.

This decision also led to bugs like: #168

Solution: add explicitly named methods for modifying casing but leave the default alone
atruskie added a commit that referenced this issue Jun 1, 2015
@atruskie
More work on refactoring annotation library.
c47c465 
Also merged with master at this point to get upstream changes.

Also compelted #191
@atruskie
Copy link
Member Author

atruskie commented Jun 1, 2015

Addressed in c47c465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug triage:medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@atruskie