Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change local_variables to be a dictionary #71

Closed
mstechly opened this issue Jun 19, 2024 · 1 comment
Closed

Change local_variables to be a dictionary #71

mstechly opened this issue Jun 19, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@mstechly
Copy link
Contributor

Right now local_variables are expressed as a string of form A = B*C.
This is problematic, as it requires parsing this expression.

We should refactor local_variables to be a dictionary: {"A": "B*C"}, it will simplify logic in a couple of places.

While doing this refactor, one should also find all the occurences of split_equation and see if it makes sense to refactor them as well.
@mstechly mstechly added the good first issue Good for newcomers label Jun 19, 2024
@dexter2206 dexter2206 mentioned this issue Jul 5, 2024
Merged
3 tasks
@dexter2206
Copy link
Contributor

Fixed via #79

@bdg221 bdg221 mentioned this issue Aug 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dexter2206 @mstechly