Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor icon, slider bar, and slider arrow animation #10

Open
kolibril13 opened this issue Jul 9, 2022 · 6 comments
Open

Cursor icon, slider bar, and slider arrow animation #10

kolibril13 opened this issue Jul 9, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@kolibril13
Copy link
Member

kolibril13 commented Jul 9, 2022

juxtapose.js has the following behaviour when the mouse hovers over the canvas:

Screen.Recording.2022-07-09.at.13.07.01.mov
  1. The mouse changes when the canvas is selected
  2. The mouse changes when it comes close to the slider arrows
  3. The arrows move when the mouse is close to indicate the splitview option.

Reading the silder bar: Do we want to keep the bar at all?
I think it can be useful to have it in some situations, e.g. to indicate where the line is and to indicate that it's a widget at all, and not a simple displayed image.
But then there are situations where it would be nice to not have the slider, in order to have an even closer look on small image changes.
@christopher-besch what do you think about making the slider bar optional?

@christopher-besch
Copy link
Member

christopher-besch commented Jul 9, 2022

I do think a slider bar is useful but would want to make it optional. That really isn't difficult at all. All those animations can't be copied from reveal.js because it's using entirely different underlying technology. Implementing it again shouldn't be so hard anyways. Personally I don't like the animations so if it were up to me I'd strip them form the ToDo list. If we do add them, I want them to be optional. And I don't have a clear opinion on changing the cursor yet.

@kolibril13
Copy link
Member Author

Making a slider bar optional sounds like a good idea!

And I don't have a clear opinion on changing the cursor yet.

I think this could be helpful to distinguish a normal image canvas from a splitview canvas

@christopher-besch
Copy link
Member

Could you try the current version? What do you think about it atm?

@kolibril13
Copy link
Member Author

I like the double arrow cursor.
I think it might be nice to have the "Click" pointing finger arrow when the cursor is on the canvas, and the double arrow cursor only when the curser is close to the silder bar. That would in my opinion indicate better the "Grab" mode, and the "Click" mode to move the slider to new positions.

@christopher-besch
Copy link
Member

Ok, I'll implement it. Is this something that has to be implemented before merging this into Jupyter Splitview or can I focus on other tasks first?

@christopher-besch christopher-besch added the enhancement New feature or request label Jul 11, 2022
@kolibril13
Copy link
Member Author

That's only a nice to have, so I think we can make the merge of Jupyter splitview the priority right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants