Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flex: forbidden_ continuous_pickup_or_drop_off #1814

Open
emmambd opened this issue Sep 9, 2024 · 4 comments · May be fixed by #1941
Open

Flex: forbidden_ continuous_pickup_or_drop_off #1814

emmambd opened this issue Sep 9, 2024 · 4 comments · May be fixed by #1941
Assignees
@qcdyx
Labels
flex Rules and rule changes related to GTFS-Flex. new rule New rule to be added status: Needs triage Applied to all new issues
Milestone
7.0 Validator Rel...

Comments

@emmambd
Copy link
Contributor

emmambd commented Sep 9, 2024 •
edited by qcdyx
Loading

Describe the problem

Validation rule to add to support Flex.

Describe the new validation rule

File name Spec language Notice to update or add Validator logic Notice table columns
routes.txt arrival_time, departure_timeroutes.continuous_pickup, routes.continuous_drop_off

Conditionally Forbidden: Forbidden if stop_times.start_pickup_drop_off_window or stop_times.end_pickup_drop_off_window are defined for any trip of this route.
- Optional otherwise

 forbidden_ continuous_pickup_or_drop_off ERROR:

Generate if
routes.continuous_pickup OR routes.continuous_drop_off are included AND

stop_times.start_pickup_drop_off_window OR
stop_times.end_pickup_drop_off_window

are defined for any trip of this route.

 • routeCsvRowNumber • trip_idA with stop_times records with start_pickup_drop_off_window or end_pickup_drop_off_window • trip_idB with stop_times records with start_pickup_drop_off_window or end_pickup_drop_off_window (there can be several trip_ids associated)

Sample GTFS datasets

No response

Severity

ERROR

Additional context

No response
@emmambd emmambd added status: Needs triage Applied to all new issues new rule New rule to be added labels Sep 9, 2024
@emmambd emmambd added this to the 7.0 Validator Release milestone Sep 9, 2024
@emmambd emmambd added the flex Rules and rule changes related to GTFS-Flex. label Dec 2, 2024
@qcdyx qcdyx self-assigned this Jan 7, 2025
@tzujenchanmbd
Copy link

Sorry for the last minute adjustment. There should be logical changes due to google/transit#528

@tzujenchanmbd
Copy link

Old-

ERROR:
Generate if
routes.continuous_pickup OR routes.continuous_drop_off are included
AND

stop_times.start_pickup_drop_off_window OR
stop_times.end_pickup_drop_off_window

are defined for any trip of this route.

New:

ERROR:
Generate if
routes.continuous_pickup OR routes.continuous_drop_off are NOT 1 or empty
AND

stop_times.start_pickup_drop_off_window OR
stop_times.end_pickup_drop_off_window

are defined for any trip of this route.

@qcdyx
Copy link
Contributor

qcdyx commented Jan 13, 2025 •
edited by emmambd
Loading

@emmambd Please indicate the naming of the rule.

Name: continue_pickup_drop_off
Description: Continuous pickup or drop-off are forbidden when routes.continuous_pickup or routes.continuous_drop_off are 2 or 3 and stop_times.start_pickup_drop_off_window or stop_times.end_pickup_drop_off_window are defined for any trip of this route.

@emmambd
Copy link
Contributor Author

emmambd commented Jan 13, 2025

@qcdyx Minor change of your description above to remove the double negative

@qcdyx qcdyx linked a pull request Jan 13, 2025 that will close this issue
Open
5 tasks
@qcdyx qcdyx linked a pull request Jan 13, 2025 that will close this issue
feat: 1814 flex forbidden continuous pickup or drop off #1941
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qcdyx qcdyx

Labels
flex Rules and rule changes related to GTFS-Flex. new rule New rule to be added status: Needs triage Applied to all new issues
Projects
None yet
Milestone
7.0 Validator Release
Development

Successfully merging a pull request may close this issue.

feat: 1814 flex forbidden continuous pickup or drop off MobilityData/gtfs-validator
3 participants
@qcdyx @emmambd @tzujenchanmbd