Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Calendar module: maximumEntries not applied from global level #3718

Closed
2 of 4 tasks
vdborght opened this issue Feb 5, 2025 · 3 comments
Closed
2 of 4 tasks
Labels

Comments

@vdborght
Copy link

vdborght commented Feb 5, 2025

Environment

MagicMirror² version: 2.30
Node version: 23.7
npm version: 10.9.2
Platform: Raspberry Pi OS 6.6.74+rpt-rpi-v8

Which start option are you using?

npm run start

Are you using PM2?

Yes

Module

calendar

Have you tried disabling other modules?

  • Yes
  • No

Have you searched if someone else has already reported the issue on the forum or in the issues?

  • Yes

What did you do?

After a few years, I decided to upgrade my MagicMirror instance to the latest.
To have a "clean" system, I reinstalled the whole system (from OS to MM to modules) and restored my MM configs and CSS.

Doing this I noticed that only 10 events were being retrieved per calendar.
A bit of debug shows that I had maximumEntries only defined on the "config" level and this doesn't get applied

After defining maximumEntries on the "config/calendar" level (for each calendar separately), it now works.

What did you expect to happen?

Defining maximumEntries on the "config" level of the calendar module is enough to apply to all calendars and 100 events are shown and defined.

What actually happened?

Only 10 entries are shown instead of the defined 100.

Additional comments

No response

Participation

  • I am willing to submit a pull request for this change.
@vdborght vdborght added the bug label Feb 5, 2025
@sdetweil
Copy link
Collaborator

sdetweil commented Feb 5, 2025

@vdborght
Copy link
Author

vdborght commented Feb 5, 2025

Seems that "fix clippings" does a lot more than just fixing clipped titles ;-)
I'll be closing this bug report.

Thank you!
Peter

@vdborght vdborght closed this as completed Feb 5, 2025
@sdetweil
Copy link
Collaborator

sdetweil commented Feb 5, 2025

it does NOT clip off the events collected before broadcast

@sdetweil sdetweil pinned this issue Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants