-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] when a calendar event listed as New York TZ is processed on a later timezone (chicago) the time shown is incorrect #3701
Comments
Adding my own example here in the hopes it will help. I am pulling my work Outlook calendar into MM through an ics file, and have the below event that was created by someone in ET, while I am in Chicago in CT. The event is today at 2pm CT, but was showing on my MM as 5pm. I tried modifying the 2 lines of code specified in pull 3702, but that makes it show as noon now. Perhaps there are other edits I simply missed.
|
are you using MagicMirror version 2.30 |
Yes. Installed fresh just 2 weeks ago. |
OK, I'll check, but it's probably the time zone value. |
can you add
To end of the logLevel list in config.js
Then after it displays the events ctrl-q Same user id at gmail |
can you install the develop branch make sure to switch back to master later to upgrade to next release use my upgrade script it will adjust the branch as required. |
Confirmed the develop branch works. Thank you! I'll switch back to master and await the next release in a couple of months. Great work! |
you can stay on develop til then april 1 i meant switch back to |
I have another datapoint. I have an event that displays at these times:
Here is the iCal for that event (minus personal information):
I'm in CST; I'm not sure what time zone the original event was made in (though I see New York in the iCal). Thoughts? |
@nrabins please checkout/try the develop branch as listed above, which contains the fix for this issue |
@sdetweil I have (the develop data point above was obtained from an up-to-date develop branch) and it doesn't match the expected 12:30 time. |
because it has a recurrence id it is part of a recurring sequence, rrule can you find that? the uid will match |
Does this look correct? It was the only RRULE in any of the events with that UID.
|
i need to see both complete vevents |
Event with RRULE:
Upcoming event:
|
thx, i will debug tomorrow morning |
works perfect with the develop branch after this issues pr merge, 3 weeks ago
find this code in calendarfetcherutils.js eventDiff = nowDiff - eventDiff; //-180 //<---- this is the new line, 669
Log.debug("now looking back east delta diff=", eventDiff); |
@nrabins can you verify? |
Environment
System information:
SYSTEM: manufacturer: System manufacturer; model: System Product Name; virtual: false
OS: platform: linux; distro: Ubuntu; release: 22.04.5 LTS; arch: x64; kernel: 5.15.0-130-generic
VERSIONS: electron: 32.2.8; used node: 22.13.0; installed node: 22.13.0; npm: 10.9.2; pm2: 5.4.3
OTHER: timeZone: America/Chicago; ELECTRON_ENABLE_GPU: undefined
Which start option are you using?
npm run start
Are you using PM2?
No
Module
calendar
Have you tried disabling other modules?
Have you searched if someone else has already reported the issue on the forum or in the issues?
What did you do?
Steps to reproduce the issue:
use this ics event
view from system on Chicago timezone
What did you expect to happen?
time displayed 17:30
as event is 18L30 East coast time
What actually happened?
time displayed is 22:30
Additional comments
No response
Participation
The text was updated successfully, but these errors were encountered: