Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if MM_PORT is used to override what is in config file, the node serveronly displays the config.js value #3696

Open
sdetweil opened this issue Jan 14, 2025 · 2 comments

Comments

@sdetweil
Copy link
Collaborator

sdetweil commented Jan 14, 2025

V 2.31.0-develop

config.js
   port:8090

console

export MM_PORT=9005
node serveronly

output

[2025-01-14 08:35:53.699] [INFO]  
>>>   Ready to go! Please point your browser to: http://0.0.0.0:8090   <<< 

from

serveronly/index.js:
   Log.info(`\n>>>   Ready to go! Please point your browser to: ${httpType}://${bindAddress}:${config.port}   <<<`);

MM is correctly on port 9005
only message is incorrect

npm start does not display that message

@khassel
Copy link
Collaborator

khassel commented Jan 14, 2025

simple fix

       Log.info(`\n>>>   Ready to go! Please point your browser to: ${httpType}://${bindAddress}:${global.mmPort || config.port}   <<<`);

will provide a PR ...

@sdetweil
Copy link
Collaborator Author

gotta know about global.mmPort!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants