From f9f11c6d60dc5617046d4cf9f48e53386ab489d0 Mon Sep 17 00:00:00 2001
From: Alan Chu <alanchu@Alans-Air.lan>
Date: Tue, 5 Nov 2024 22:18:33 -0800
Subject: [PATCH 1/3] remove List[int] as input types
---
src/lightning/fabric/accelerators/cpu.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/lightning/fabric/accelerators/cpu.py b/src/lightning/fabric/accelerators/cpu.py
index 1bcec1b2ac278..873d0aa160b78 100644
--- a/src/lightning/fabric/accelerators/cpu.py
+++ b/src/lightning/fabric/accelerators/cpu.py
@@ -39,13 +39,13 @@ def teardown(self) -> None:
@staticmethod
@override
- def parse_devices(devices: Union[int, str, List[int]]) -> int:
+ def parse_devices(devices: Union[int, str]) -> int:
"""Accelerator device parsing logic."""
return _parse_cpu_cores(devices)
@staticmethod
@override
- def get_parallel_devices(devices: Union[int, str, List[int]]) -> List[torch.device]:
+ def get_parallel_devices(devices: Union[int, str]) -> List[torch.device]:
"""Gets parallel devices for the Accelerator."""
devices = _parse_cpu_cores(devices)
return [torch.device("cpu")] * devices
@@ -72,7 +72,7 @@ def register_accelerators(cls, accelerator_registry: _AcceleratorRegistry) -> No
)
-def _parse_cpu_cores(cpu_cores: Union[int, str, List[int]]) -> int:
+def _parse_cpu_cores(cpu_cores: Union[int, str]) -> int:
"""Parses the cpu_cores given in the format as accepted by the ``devices`` argument in the
:class:`~lightning.pytorch.trainer.trainer.Trainer`.
From d68534aed2f48814fa67304e5a7b17b3fb3c283d Mon Sep 17 00:00:00 2001
From: Alan Chu <alanchu@Alans-Air.lan>
Date: Tue, 5 Nov 2024 22:35:02 -0800
Subject: [PATCH 2/3] update comment
---
src/lightning/fabric/accelerators/cpu.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lightning/fabric/accelerators/cpu.py b/src/lightning/fabric/accelerators/cpu.py
index 873d0aa160b78..0334210ecd76d 100644
--- a/src/lightning/fabric/accelerators/cpu.py
+++ b/src/lightning/fabric/accelerators/cpu.py
@@ -77,7 +77,7 @@ def _parse_cpu_cores(cpu_cores: Union[int, str]) -> int:
:class:`~lightning.pytorch.trainer.trainer.Trainer`.
Args:
- cpu_cores: An int > 0.
+ cpu_cores: An int > 0 or a string that can be converted to an int > 0.
Returns:
An int representing the number of processes
From c3bf0832f688b21a3e0560b8fbe1530cc0fa3d48 Mon Sep 17 00:00:00 2001
From: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Date: Wed, 13 Nov 2024 19:48:56 +0100
Subject: [PATCH 3/3] pt
---
src/lightning/pytorch/accelerators/cpu.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/lightning/pytorch/accelerators/cpu.py b/src/lightning/pytorch/accelerators/cpu.py
index 735312b363d11..a85a959ab66e0 100644
--- a/src/lightning/pytorch/accelerators/cpu.py
+++ b/src/lightning/pytorch/accelerators/cpu.py
@@ -48,13 +48,13 @@ def teardown(self) -> None:
@staticmethod
@override
- def parse_devices(devices: Union[int, str, List[int]]) -> int:
+ def parse_devices(devices: Union[int, str]) -> int:
"""Accelerator device parsing logic."""
return _parse_cpu_cores(devices)
@staticmethod
@override
- def get_parallel_devices(devices: Union[int, str, List[int]]) -> List[torch.device]:
+ def get_parallel_devices(devices: Union[int, str]) -> List[torch.device]:
"""Gets parallel devices for the Accelerator."""
devices = _parse_cpu_cores(devices)
return [torch.device("cpu")] * devices