Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encapsulate logic in DistributedType #6079

Closed
1 of 3 tasks
carmocca opened this issue Feb 19, 2021 · 1 comment
Closed
1 of 3 tasks

Encapsulate logic in DistributedType #6079

carmocca opened this issue Feb 19, 2021 · 1 comment
Labels
good first issue Good for newcomers help wanted Open to be worked on refactor

Comments

@carmocca
Copy link
Contributor

carmocca commented Feb 19, 2021 •
edited
Loading

🚀 Feature

Any logic to compare different DistributedTypes should be encapsulated by the enum itself.

Motivation

Additional context

https://github.com/PyTorchLightning/pytorch-lightning/blob/0b271474e5cc35a40009559d6c4488ab3b02723e/pytorch_lightning/utilities/enums.py#L51-L69

cc: @awaelchli
@carmocca carmocca added feature Is an improvement or enhancement help wanted Open to be worked on good first issue Good for newcomers refactor labels Feb 19, 2021
@carmocca carmocca mentioned this issue Feb 19, 2021
Merged
12 tasks
@carmocca carmocca removed the feature Is an improvement or enhancement label Mar 8, 2021
@carmocca
Copy link
Contributor Author

Duplicate of #5478

@carmocca carmocca marked this as a duplicate of #5478 Mar 25, 2021
@slumericanBx slumericanBx mentioned this issue Dec 27, 2023
Open
@slumericanBx slumericanBx mentioned this issue Jan 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Open to be worked on refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carmocca